From: Dave Abrahams <dave@boostpro.com>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: "ding\@gnus.org" <ding@gnus.org>
Subject: Re: Proposal: gnus-refer-article
Date: Sat, 03 Aug 2013 09:24:59 -0700 [thread overview]
Message-ID: <m2ob9ehhd0.fsf@cube.luannocracy.com> (raw)
In-Reply-To: <m3a9kzc903.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Sat, 03 Aug 2013 13:24:28 +0200")
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
on Sat Aug 03 2013, Lars Magne Ingebrigtsen <larsi-AT-gnus.org> wrote:
> Dave Abrahams <dave@boostpro.com> writes:
>
>>> But why? If you have a (say) nnml group that contains an article you've
>>> copied from somewhere else, why shouldn't you be allowed to warp
>>> somewhere else?
>>
>> I don't know why. I've tried several times to get you to accept the
>> patch that lifts that restriction.
>
> Since nobody else seems to have any objections, please re-send a patch
> and I'll apply it.
voilà:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Allow-warping-from-non-virtual-groups.patch --]
[-- Type: text/x-patch, Size: 1721 bytes --]
From 9cdfc3029a64880efddaea0713227218508ca0d6 Mon Sep 17 00:00:00 2001
From: Dave Abrahams <dave@boostpro.com>
Date: Sat, 3 Aug 2013 09:18:28 -0700
Subject: [PATCH] Allow warping from non-virtual groups
---
lisp/gnus-int.el | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/lisp/gnus-int.el b/lisp/gnus-int.el
index 6aa874f..c067b31 100644
--- a/lisp/gnus-int.el
+++ b/lisp/gnus-int.el
@@ -582,18 +582,17 @@ This is the string that Gnus uses to identify the group."
(gnus-group-method group)))
(defun gnus-warp-to-article ()
- "Jump from an article in a virtual group to the article in its real group.
-Does nothing in a real group."
+ "Jump from an article in a group where it did not originate to
+the article in its original group."
(interactive)
- (when (gnus-virtual-group-p gnus-newsgroup-name)
- (let ((gnus-command-method
- (gnus-find-method-for-group gnus-newsgroup-name)))
- (or
- (when (gnus-check-backend-function
- 'warp-to-article (car gnus-command-method))
- (funcall (gnus-get-function gnus-command-method 'warp-to-article)))
- (and (bound-and-true-p gnus-registry-enabled)
- (gnus-try-warping-via-registry))))))
+ (let ((gnus-command-method
+ (gnus-find-method-for-group gnus-newsgroup-name)))
+ (or
+ (when (gnus-check-backend-function
+ 'warp-to-article (car gnus-command-method))
+ (funcall (gnus-get-function gnus-command-method 'warp-to-article)))
+ (and (bound-and-true-p gnus-registry-enabled)
+ (gnus-try-warping-via-registry)))))
(defun gnus-request-head (article group)
"Request the head of ARTICLE in GROUP."
--
1.8.3.1
[-- Attachment #3: Type: text/plain, Size: 19 bytes --]
--
Dave Abrahams
next prev parent reply other threads:[~2013-08-03 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 6:42 Dave Abrahams
2013-08-01 16:15 ` Lars Magne Ingebrigtsen
2013-08-02 14:05 ` Dave Abrahams
2013-08-02 14:13 ` Lars Magne Ingebrigtsen
2013-08-02 15:00 ` Dave Abrahams
2013-08-03 11:24 ` Lars Magne Ingebrigtsen
2013-08-03 16:24 ` Dave Abrahams [this message]
2013-08-05 2:16 ` Lars Magne Ingebrigtsen
2013-08-05 5:10 ` Dave Abrahams
2013-09-29 2:12 ` Dave Abrahams
2013-10-03 3:27 ` Eric Abrahamsen
2014-02-01 0:00 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ob9ehhd0.fsf@cube.luannocracy.com \
--to=dave@boostpro.com \
--cc=ding@gnus.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).