Gnus development mailing list
 help / color / mirror / Atom feed
From: SL Baur <steve@xemacs.org>
Subject: [PATCH] pgnus-0.34 nits
Date: 10 Oct 1998 19:48:49 -700	[thread overview]
Message-ID: <m2ogrjq0dq.fsf@altair.xemacs.org> (raw)

The attached patch fixes one major new problem and an annoying
long-standing one.  The new problem is that pgnus can't send any
outgoing mail due to the `message-check' macro getting called for
invisible text but the macro is used before it is declared leading to
a beep in XEmacs.

The nit is that in PGP 5/GNUPG signed messages, an extra line is added 
to the signature that Gnus fails to wash away.

1998-10-10  SL Baur  <steve@altair.xemacs.org>

	* message.el (message-check): Move message-check macro above where 
	it is first used.

	* gnus-art.el (article-hide-pgp): Hide the PGP 5/GNUPG Hash: line.

--- lisp/message.el~	Sat Oct 10 17:32:05 1998
+++ lisp/message.el	Sat Oct 10 19:39:00 1998
@@ -1994,6 +1994,15 @@
   "Send the current message via news."
   (funcall message-send-news-function arg))
 
+(defmacro message-check (type &rest forms)
+  "Eval FORMS if TYPE is to be checked."
+  `(or (message-check-element ,type)
+       (save-excursion
+	 ,@forms)))
+
+(put 'message-check 'lisp-indent-function 1)
+(put 'message-check 'edebug-form-spec '(form body))
+
 (defun message-fix-before-sending ()
   "Do various things to make the message nice before sending it."
   ;; Make sure there's a newline at the end of the message.
@@ -2265,15 +2274,6 @@
 ;;;
 ;;; Header generation & syntax checking.
 ;;;
-
-(defmacro message-check (type &rest forms)
-  "Eval FORMS if TYPE is to be checked."
-  `(or (message-check-element ,type)
-       (save-excursion
-	 ,@forms)))
-
-(put 'message-check 'lisp-indent-function 1)
-(put 'message-check 'edebug-form-spec '(form body))
 
 (defun message-check-element (type)
   "Returns non-nil if this type is not to be checked."
--- lisp/gnus-art.el~	Sat Oct 10 17:32:02 1998
+++ lisp/gnus-art.el	Sat Oct 10 17:50:47 1998
@@ -1031,6 +1031,9 @@
 	;; Hide the "header".
 	(when (search-forward "\n-----BEGIN PGP SIGNED MESSAGE-----\n" nil t)
 	  (delete-region (1+ (match-beginning 0)) (match-end 0))
+	  ;; PGP 5 and GNU PG add a `Hash: <>' comment, hide that too
+	  (when (looking-at "Hash:.*$")
+	    (delete-region (point) (1+ (gnus-point-at-eol))))
 	  (setq beg (point))
 	  ;; Hide the actual signature.
 	  (and (search-forward "\n-----BEGIN PGP SIGNATURE-----\n" nil t)


                 reply	other threads:[~1998-10-11  2:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ogrjq0dq.fsf@altair.xemacs.org \
    --to=steve@xemacs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).