Re: closing all inactive server connections

[Ted Zlatanov <tzz@lifelogs.com>]

On Mon, 30 Jul 2007 15:22:50 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote: 

>>>>>> Ted Zlatanov wrote:
>> On Fri, 27 Jul 2007 13:06:14 -0400 Ted Zlatanov <tzz@lifelogs.com> wrote:

TZ> Here's a version of gnus-server-close-all-servers that works on all the
TZ> server in the buffer.  I preserved the old (buggy I think) behavior with
TZ> the `some' parameter.  Can I commit this change?  It works for me.

>> I had to revise the function, apparently I need both lists.

>> (defun gnus-server-close-all-servers ()
>> "Close all servers."
>> (interactive)
>> (let ((servers (append
>> gnus-inserted-opened-servers
>> gnus-server-alist)))
>> (dolist (server servers)
>> (gnus-server-close-server (car server)))))

>> I tested this on several Gnus setups and it seems OK.

KY> I can agree to this change if it is really helpful to you.  But
KY> you still need to type `C-g' for almost servers when the VPN is
KY> disconnected, don't you?  Even so, is it really helpful to you?
KY> I don't have a problem like yours and don't know how to reproduce
KY> it without VPN, so don't know how to solve it so far.

Yes, I need C-g, but I don't need to

1) go to each opened server
2) press C
3) press C-g

(repeat 3-4 times for each foreign server that's hung)

now I just

1) M-c
2) press C-g for whatever hangs.

Much better user experience.  Of course, avoiding the C-g would be even
better; my other question in the original e-mail was if I can tell Emacs
all these connections are truly dead so Gnus doesn't hang trying to
close them.

KY> In addition, isn't it unnecessary to use `let'?  I mean:

KY> (defun gnus-server-close-all-servers ()
KY>   "Close all servers."
KY>   (interactive)
KY>   (dolist (server gnus-inserted-opened-servers)
KY>     (gnus-server-close-server (car server)))
KY>   (dolist (server gnus-server-alist)
KY>     (gnus-server-close-server (car server))))

KY> or

KY> (defun gnus-server-close-all-servers ()
KY>   "Close all servers."
KY>   (interactive)
KY>   (dolist (server (append gnus-inserted-opened-servers gnus-server-alist))
KY>     (gnus-server-close-server (car server))))

I was debugging, so the variable was handy.  I am OK with your version.

TZ> Unfortunately there were tabs in the gnus-srvr.el file (aren't we
TZ> supposed to use untabify?) so the patch comes out too long.

KY> I cannot understand what you want to do.  gnus-srvr.el in the CVS
KY> trunk uses tabs for the indentations that require eight or more
KY> characters width (except for only one line).  The reason the patch
KY> is big should be that you, some program or other untabified them.
KY> Do you think that it should be applied to all the Gnus sources?
KY> I don't agree.  IMO, whoever changes the Gnus sources should use
KY> the default value for the `indent-tabs-mode' variable.

I was told by Lars a while ago to use untabify on Gnus commits, so I do
as a general rule.  That's what I mean by my question "aren't we
supposed to use untabify?"

I didn't know the convention had changed, that's all.  I'm happy to
stick with whatever is the current convention.  Let me know if you want
me to commit the change, or if you'll commit your version instead.

Thanks
Ted