Re: September Gnus 0.31 is released

[Steven L Baur <steve@miranova.com>]

This article should not buttonize either, as in Manoj's original.

>>>>> "mb" == Mark Borges <mdb@cdc.noaa.gov> writes:

mb> Weird.
mb> *All* the URL's in *all* the followups to Manoj's original article
mb> (#6899) -- mine(#6927), Manoj's(#6927) and Steve's(#6928) have been
mb> turned into buttons. The original article (#6899) has no buttons,
mb> except for those in the signature block.

mb> Even the ones with a space after a URL, e.g., both

mb>      <URL: ftp://ftp.pilgrim.umass.edu/pub/misc/ding/>
mb> and
mb>      <URL:ftp://ftp.pilgrim.umass.edu/pub/misc/ding/>

mb> work, so that apparently wasn't the problem.

mb> So what is so unique about the original #6899?

The .signature.  Unhide the original .signature and you will find a
quote from Larry Wall attributed in a fashion typically expected at
the top of an article.  I traced it with the debugger, and basically
Gnus is testing each of the entries in gnus-button-alist, without
resetting point to the beginning of the article.  The goose is cooked
on an original article (no citation at the top), and a citation in the
.signature -- only the remainder of the .signature gets buttonized.

Naturally anyone running Gnus 5 will not see this, since Gnus 5 uses
only a single regexp, not an alist and the problem cannot arise in
that case.

Here's the fix:
===================================================================
RCS file: RCS/ChangeLog,v
retrieving revision 1.31
diff -u -r1.31 ChangeLog
--- ChangeLog	1996/01/26 16:12:09	1.31
+++ ChangeLog	1996/01/26 23:10:45
@@ -1,3 +1,8 @@
+Fri Jan 26 15:10:09 1996  Steven L. Baur  <steve@miranova.com>
+
+	* gnus-vis.el (gnus-article-add-buttons): Need to reset point to top
+	of article before trying the next regexp in the gnus-button-alist.
+
 Fri Jan 26 07:47:59 1996  Lars Magne Ingebrigtsen  <larsi@eistla.ifi.uio.no>
 
 	* gnus.el (gnus): Goto the first unread group.

===================================================================
RCS file: RCS/gnus-vis.el,v
retrieving revision 1.12
diff -u -r1.12 gnus-vis.el
--- gnus-vis.el	1996/01/26 16:12:09	1.12
+++ gnus-vis.el	1996/01/26 23:09:17
@@ -1397,6 +1397,7 @@
       (setq beg (point))
       (while (setq entry (pop alist))
 	(setq regexp (car entry))
+	(goto-char beg)
 	(while (re-search-forward regexp nil t)
 	  (let* ((start (and entry (match-beginning (nth 1 entry))))
 		 (end (and entry (match-end (nth 1 entry))))

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be proofread for $250/hour.
In article <ThisIsAGnusBug12345@miranova.com> somebody wrote: