From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/4933 Path: main.gmane.org!not-for-mail From: Steven L Baur Newsgroups: gmane.emacs.gnus.general Subject: Re: September Gnus 0.31 is released Date: 26 Jan 1996 15:17:10 -0800 Organization: Miranova Systems, Inc. Message-ID: References: <199601252354.SAA01433@belthil.pilgrim.umass.edu> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 (generated by tm-edit 7.41) Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1035145609 31279 80.91.224.250 (20 Oct 2002 20:26:49 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 20:26:49 +0000 (UTC) Return-Path: ding-request@ifi.uio.no Original-Received: from ifi.uio.no (ifi.uio.no [129.240.64.2]) by miranova.com (8.7.3/8.6.9) with SMTP id PAA05048 for ; Fri, 26 Jan 1996 15:56:23 -0800 Original-Received: from miranova.com (steve@miranova.com [204.212.162.100]) by ifi.uio.no with ESMTP (8.6.11/ifi2.4) id for ; Sat, 27 Jan 1996 00:20:16 +0100 Original-Received: (from steve@localhost) by miranova.com (8.7.3/8.6.9) id PAA04829; Fri, 26 Jan 1996 15:17:16 -0800 Original-To: ding@ifi.uio.no X-Url: http://www.miranova.com/%7Esteve/ In-Reply-To: Mark Borges's message of 26 Jan 1996 12:50:34 -0800 Original-Lines: 68 X-Mailer: September Gnus v0.32/XEmacs 19.13 Xref: main.gmane.org gmane.emacs.gnus.general:4933 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:4933 This article should not buttonize either, as in Manoj's original. >>>>> "mb" == Mark Borges writes: mb> Weird. mb> *All* the URL's in *all* the followups to Manoj's original article mb> (#6899) -- mine(#6927), Manoj's(#6927) and Steve's(#6928) have been mb> turned into buttons. The original article (#6899) has no buttons, mb> except for those in the signature block. mb> Even the ones with a space after a URL, e.g., both mb> mb> and mb> mb> work, so that apparently wasn't the problem. mb> So what is so unique about the original #6899? The .signature. Unhide the original .signature and you will find a quote from Larry Wall attributed in a fashion typically expected at the top of an article. I traced it with the debugger, and basically Gnus is testing each of the entries in gnus-button-alist, without resetting point to the beginning of the article. The goose is cooked on an original article (no citation at the top), and a citation in the .signature -- only the remainder of the .signature gets buttonized. Naturally anyone running Gnus 5 will not see this, since Gnus 5 uses only a single regexp, not an alist and the problem cannot arise in that case. Here's the fix: =================================================================== RCS file: RCS/ChangeLog,v retrieving revision 1.31 diff -u -r1.31 ChangeLog --- ChangeLog 1996/01/26 16:12:09 1.31 +++ ChangeLog 1996/01/26 23:10:45 @@ -1,3 +1,8 @@ +Fri Jan 26 15:10:09 1996 Steven L. Baur + + * gnus-vis.el (gnus-article-add-buttons): Need to reset point to top + of article before trying the next regexp in the gnus-button-alist. + Fri Jan 26 07:47:59 1996 Lars Magne Ingebrigtsen * gnus.el (gnus): Goto the first unread group. =================================================================== RCS file: RCS/gnus-vis.el,v retrieving revision 1.12 diff -u -r1.12 gnus-vis.el --- gnus-vis.el 1996/01/26 16:12:09 1.12 +++ gnus-vis.el 1996/01/26 23:09:17 @@ -1397,6 +1397,7 @@ (setq beg (point)) (while (setq entry (pop alist)) (setq regexp (car entry)) + (goto-char beg) (while (re-search-forward regexp nil t) (let* ((start (and entry (match-beginning (nth 1 entry)))) (end (and entry (match-end (nth 1 entry)))) -- steve@miranova.com baur Unsolicited commercial e-mail will be proofread for $250/hour. In article somebody wrote: