bug: enabling adaptive scoring via score file doesn't work

bug: enabling adaptive scoring via score file doesn't work

[Alex Schroeder]

I just updated Gnus from CVS.  Enabling adaptive scoring via my score
file doesn't work.

First, the evidence that adaptive scoring doesn't work.  Assume this
article in the summary buffer:

    03-Aug   47: Jonathan LF King     Re: undo an undo

Using "V t" I get the message:

 "No score rules apply to the current article (default score 0)."

I then check what score file is being used.  I use "V e" and my
emacs.SCORE file is opened.  (This is correct.  It is the score file I
set via topic parameters.)  It reads, more or less, like this:

(("from"
  ...
  ("Grossjohann" nil nil s))
 ("subject"
  ...
  ("sql" nil nil s))
 ("references"
  ("<m2[0-9a-z]+\\.fsf\\(_-_\\)?@.*snail\\.nowhere\\.ch>" nil nil r))
 ("message-id"
  ("<m2[0-9a-z]+\\.fsf\\(_-_\\)?@.*snail\\.nowhere\\.ch>" nil nil r))
 (adapt t)
 (adapt-file "/home/alex/News/emacs.ADAPT"))

This should switch adaptive scoring on and use the emacs.ADAPT file.
I open the emacs.ADAPT file.  It is about 35k.  I search for the
string "undo an undo".  Here it is:

(("subject" ... ("undo an undo" -6970 730699 f) ...))

But somehow, this score is not applied.

The weird thing is this, however.  I kill the article using "C-k" and
exit Gnus.  I look at the emacs.ADAPT file again.  Here it is:

(("subject" ... ("undo an undo" -7970 730699 f) ...))

This is correct!  Here is my gnus-default-adaptive-score-alist:

'(... (gnus-killed-mark (subject -1000)) ...)

Therefore, the adaptive scores are updated as I leave the group, but
when I enter the group, the scores are not applied.

Help!

Alex.
-- 
http://www.emacswiki.org/

Re: bug: enabling adaptive scoring via score file doesn't work

[Lars Magne Ingebrigtsen]

Alex Schroeder <alex@gnu.org> writes:

> Therefore, the adaptive scores are updated as I leave the group, but
> when I enter the group, the scores are not applied.

Right.  `gnus-newsgroup-adaptive' it t when you enter the group, but
it sounds like Gnus doesn't find the score files when applying the
scores.

What does `(gnus-all-score-files)' evaluate to after you've entered
the group?

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: bug: enabling adaptive scoring via score file doesn't work

[Alex Schroeder]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Alex Schroeder <alex@gnu.org> writes:
>
>> Therefore, the adaptive scores are updated as I leave the group, but
>> when I enter the group, the scores are not applied.
>
> Right.  `gnus-newsgroup-adaptive' it t when you enter the group, but
> it sounds like Gnus doesn't find the score files when applying the
> scores.
>
> What does `(gnus-all-score-files)' evaluate to after you've entered
> the group?

In the summary buffer, I get this:

("/home/alex/News/nnml:emacs.gnus.SCORE" "/home/alex/News/emacs.SCORE")

BTW, just because I was curious, I tried 

(gnus-score-score-files "nnml:emacs.gnus") 

and got this (which includes the */emacs.ADAPT score file).

("/home/alex/News/nnml:mail.spam.ADAPT"
"/home/alex/News/nnml:mail.misc.ADAPT"
"/home/alex/News/nnml:ion.ADAPT" "/home/alex/News/nnml:friends.ADAPT"
"/home/alex/News/nnml:family.ADAPT"
"/home/alex/News/nnml:emacs.sql.ADAPT"
"/home/alex/News/nnml:emacs.BBDB.ADAPT"
"/home/alex/News/nnml:anschaffungen.ADAPT"
"/home/alex/News/int-fiction.SCORE"
"/home/alex/News/gnu.misc.discuss.SCORE" "/home/alex/News/emacs.SCORE"
"/home/alex/News/emacs.ADAPT" "/home/alex/News/comp.lang.lisp.SCORE")

Alex.
-- 
http://www.emacswiki.org/

Re: bug: enabling adaptive scoring via score file doesn't work

[Lars Magne Ingebrigtsen]

Alex Schroeder <alex@gnu.org> writes:

>> What does `(gnus-all-score-files)' evaluate to after you've entered
>> the group?
>
> In the summary buffer, I get this:
>
> ("/home/alex/News/nnml:emacs.gnus.SCORE" "/home/alex/News/emacs.SCORE")
>
> BTW, just because I was curious, I tried 
>
> (gnus-score-score-files "nnml:emacs.gnus") 
>
> and got this (which includes the */emacs.ADAPT score file).

Yes, but that function lists all your score files -- not only the
score files that apply to the group you name.  (No, the function names
here aren't very informative.)

I think you want:

(setq gnus-score-find-score-files-function 'gnus-score-find-hierarchical)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: bug: enabling adaptive scoring via score file doesn't work

[Alex Schroeder]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Alex Schroeder <alex@gnu.org> writes:
>
>> Therefore, the adaptive scores are updated as I leave the group, but
>> when I enter the group, the scores are not applied.
>
> Right.  `gnus-newsgroup-adaptive' it t when you enter the group, but
> it sounds like Gnus doesn't find the score files when applying the
> scores.

Following a hint by Kai on IRC, I've decided to skip the 

(adapt-file ...)

clause in the score file.  All it has now is (adapt t).  And it works!
My adaptive scoring rules only affect subjects, so there really wasn't
any reason to share the ADAPT file between the various topic
newsgroups.  Since sharing one SCORE file between the various
newsgroups works, this seems to be a good work-around for me.

It's still is a bug, though, I guess.

Alex.
-- 
http://www.emacswiki.org/