Re: Humor value: user error

[Steven L Baur <steve@miranova.com>]

>>>>> "David" == David Moore <dmoore@UCSD.EDU> writes:

> Steven L Baur <steve@miranova.com> writes:

sb> A fix would be to keep a cache of expanded directory names, and
sb> not search the same directory twice after expansion of symbolic links.

David> 	Patch below for a couple of these situations in rgnus-0.68.
David> Then again you might just want to avoid making cycles in your Gnus
David> directory trees with symlinks. ;-)

Thanks for the patches David, but there are a couple of problems.  The
ChangeLog patch is corrupted (replace the 1,25 with 1,10).  And the
patches to nnml.el and gnus-score.el do not quite correct the problem.

Apply the following patch on top of David's patch to gnus-score.el to
get one fix.

[Tested with GNU Emacs 19.34 & XEmacs 19.15]

--- gnus-score.el~	Fri Nov 22 13:54:00 1996
+++ gnus-score.el	Fri Nov 22 14:21:57 1996
@@ -2372,8 +2372,8 @@
 	nil)
        ;; Add subtrees of directory to also be searched.
        ((and (file-directory-p file)
-	     (not (member file seen)))
-	(push file seen)
+	     (not (member (file-truename file) seen)))
+	(push (file-truename file) seen)
 	(setq files (nconc (directory-files file t nil t) files)))
        ;; Add files to the list of score files.
        ((string-match regexp file)

The same correction needs to be made to the nnml.el patch.  You need
to compare (file-truename)s to really defend against symbolic links.

Even with this fix, all files will get added twice due to the trailing
slash passed in, using Karl's example.  (Which is fine enough with me).

-- 
steve@miranova.com baur
Unsolicited commercial e-mail will be billed at $250/message.
"Bill Clinton is a bore.  He doesn't have a creative bone in his
body."  -- David Brinkley