[PATCH] Make group entering work in XEmacs again

[PATCH] Make group entering work in XEmacs again

[Nelson Ferreira]

In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
add it, since it would be the default value in GNU Emacs anyway!

diff --git a/lisp/gnus-win.el b/lisp/gnus-win.el
index efe2a31..4261c3d 100644
--- a/lisp/gnus-win.el
+++ b/lisp/gnus-win.el
@@ -273,7 +273,7 @@ See the Gnus manual for an explanation of the syntax used.")
              (cond
                ((eq buf (window-buffer (selected-window)))
                 (set-buffer buf))
-               ((eq t (window-dedicated-p))
+               ((eq t (window-dedicated-p (selected-window)))
                 ;; If the window is hard-dedicated, we have a problem because
                 ;; we just can't do what we're asked.  But signaling an error,
                 ;; like `switch-to-buffer' would do, is not an option because

Re: [PATCH] Make group entering work in XEmacs again

[Katsumi Yamaoka]

nelson.ferreira@ieee.org wrote:

> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
> add it, since it would be the default value in GNU Emacs anyway!

Applied.  Thanks.  I wonder why the buildbot didn't complain to
it, though.

Re: [PATCH] Make group entering work in XEmacs again

[Nelson Ferreira]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> nelson.ferreira@ieee.org wrote:
>
>> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
>> add it, since it would be the default value in GNU Emacs anyway!
>
> Applied.  Thanks.  I wonder why the buildbot didn't complain to
> it, though.

Buildbot probably did not complain because it only surfaces at runtime.
My local build also succeeded. Only when attempting to enter a group I
got a traceback.

--Nelson

Re: [PATCH] Make group entering work in XEmacs again

[David Engster]

Nelson Ferreira writes:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> nelson.ferreira@ieee.org wrote:
>>
>>> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
>>> add it, since it would be the default value in GNU Emacs anyway!
>>
>> Applied.  Thanks.  I wonder why the buildbot didn't complain to
>> it, though.
>
> Buildbot probably did not complain because it only surfaces at runtime.
> My local build also succeeded. Only when attempting to enter a group I
> got a traceback.

xemacs should issue a warning during byte compilation (the Buildbot uses
'make fail-on-warning'), but for some reason it doesn't.

-David