From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/81968
Path: news.gmane.org!not-for-mail
From: David Engster <deng@randomsample.de>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: [PATCH] Make group entering work in XEmacs again
Date: Tue, 19 Jun 2012 09:56:31 +0200
Message-ID: <m2wr33wx8w.fsf@ibookg4-c2.pc.gwdg.de>
References: <m262ao3gzj.fsf@neumann.in.inware.org> <b4mehpcmd0i.fsf@jpl.org>
	<m21ulc2olx.fsf@neumann.in.inware.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: dough.gmane.org 1340092726 859 80.91.229.3 (19 Jun 2012 07:58:46 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Tue, 19 Jun 2012 07:58:46 +0000 (UTC)
Cc: ding@gnus.org
To: Nelson Ferreira <nelson.ferreira@ieee.org>
Original-X-From: ding-owner+M30238@lists.math.uh.edu Tue Jun 19 09:58:45 2012
Return-path: <ding-owner+M30238@lists.math.uh.edu>
Envelope-to: ding-account@gmane.org
Original-Received: from util0.math.uh.edu ([129.7.128.18])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <ding-owner+M30238@lists.math.uh.edu>)
	id 1SgtKl-0006QI-65
	for ding-account@gmane.org; Tue, 19 Jun 2012 09:58:43 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by util0.math.uh.edu with smtp (Exim 4.63)
	(envelope-from <ding-owner+M30238@lists.math.uh.edu>)
	id 1SgtJ4-0008Ez-2v; Tue, 19 Jun 2012 02:56:58 -0500
Original-Received: from mx2.math.uh.edu ([129.7.128.33])
	by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.63)
	(envelope-from <deng@randomsample.de>)
	id 1SgtJ1-0008Eo-4i
	for ding@lists.math.uh.edu; Tue, 19 Jun 2012 02:56:55 -0500
Original-Received: from quimby.gnus.org ([80.91.231.51])
	by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.76)
	(envelope-from <deng@randomsample.de>)
	id 1SgtIp-0007Jz-Hk
	for ding@lists.math.uh.edu; Tue, 19 Jun 2012 02:56:54 -0500
Original-Received: from randomsample.de ([83.169.19.17])
	by quimby.gnus.org with esmtp (Exim 4.72)
	(envelope-from <deng@randomsample.de>)
	id 1SgtIn-0001pE-37
	for ding@gnus.org; Tue, 19 Jun 2012 09:56:41 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a;
	h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=dWezl4hY3v1yCWB8v8/43M/we30LniZYYEjhRflba2k=;
	b=F61uFNTv0TQkZDY6V6Vrvfw5OeIjZeZbYjSo4vggb61mvQjGEm+OJC0NoZuAY9eGyRlN4U3CN2Uz/Rfofkk2dQpgBzXYKC4V0KrRvCBdMLm8PlTMQ3RW+vOz9GlRcLua;
Original-Received: from ibookg4-c2.pc.gwdg.de ([134.76.4.219])
	by randomsample.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72)
	(envelope-from <deng@randomsample.de>)
	id 1SgtIj-0003zu-Ds; Tue, 19 Jun 2012 09:56:37 +0200
In-Reply-To: <m21ulc2olx.fsf@neumann.in.inware.org> (Nelson Ferreira's message
	of "Mon, 18 Jun 2012 19:21:14 -0400")
User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.1 (darwin)
Mail-Copies-To: never
Mail-Followup-To: Nelson Ferreira <nelson.ferreira@ieee.org>, ding@gnus.org
X-Spam-Score: -2.0 (--)
List-ID: <ding.gnus.org>
Precedence: bulk
Xref: news.gmane.org gmane.emacs.gnus.general:81968
Archived-At: <http://permalink.gmane.org/gmane.emacs.gnus.general/81968>

Nelson Ferreira writes:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> nelson.ferreira@ieee.org wrote:
>>
>>> In XEmacs the WINDOW parameter is not optional to window-dedicated-p, so
>>> add it, since it would be the default value in GNU Emacs anyway!
>>
>> Applied.  Thanks.  I wonder why the buildbot didn't complain to
>> it, though.
>
> Buildbot probably did not complain because it only surfaces at runtime.
> My local build also succeeded. Only when attempting to enter a group I
> got a traceback.

xemacs should issue a warning during byte compilation (the Buildbot uses
'make fail-on-warning'), but for some reason it doesn't.

-David