From: Malcolm Purvis <malcolmp@xemacs.org>
To: ding@gnus.org
Subject: 'configure' doesn't preserve spaces in directory path.
Date: Mon, 04 Feb 2008 23:14:36 +1100 [thread overview]
Message-ID: <m2wspkq5oz.fsf@xemacs.org> (raw)
Back in 2006, Chris Shenton reported a bug in configure when the
installation path contains a space:
http://article.gmane.org/gmane.emacs.gnus.general/62483
In response Katsumi Yamaoka posted an improved patch:
http://article.gmane.org/gmane.emacs.gnus.general/62487
For some reason this patch hasn't been applied, but the bug is still
present, and bit me recently. Would it be possible to have this patch
applied?
Katsumi Yamaoka's patch is:
--- aclocal.m4~ 2005-10-04 08:37:27 +0000
+++ aclocal.m4 2006-04-03 23:35:24 +0000
@@ -91,7 +91,8 @@
fi
for thedir in share lib; do
potential=
- if test -d ${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp; then
+ dnl The directory name should be quoted because it might contain spaces.
+ if test -d "${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp"; then
if test "$EMACS_FLAVOR" = "xemacs"; then
lispdir="\$(prefix)/${thedir}/${EMACS_FLAVOR}/site-packages/lisp/gnus"
else
@@ -322,6 +323,28 @@
AC_SUBST(USE_FONTS)
])
+# Redefine AC_SITE_LOAD which is originally defined in general.m4.
+# ----------------------------------------------------------------
+# Look for site or system specific initialization scripts.
+m4_define([AC_SITE_LOAD],
+[# Prefer explicitly selected file to automatically selected ones.
+if test -z "$CONFIG_SITE"; then
+ if test "x$prefix" != xNONE; then
+ CONFIG_SITE="$prefix/share/config.site $prefix/etc/config.site"
+ else
+ CONFIG_SITE="$ac_default_prefix/share/config.site $ac_default_prefix/etc/config.site"
+ fi
+fi
+dnl $CONFIG_SITE should be quoted because the value might contain spaces.
+for ac_site_file in "$CONFIG_SITE"; do
+ if test -r "$ac_site_file"; then
+ AC_MSG_NOTICE([loading site script $ac_site_file])
+ sed 's/^/| /' "$ac_site_file" >&AS_MESSAGE_LOG_FD
+ . "$ac_site_file"
+ fi
+done
+])
+
ifelse(dnl Do not change this comment
arch-tag: 5c987641-c3ef-4f12-b067-028302282c66
)dnl
Thanks,
Malcolm
--
Malcolm Purvis <malcolmp@xemacs.org>
next reply other threads:[~2008-02-04 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 12:14 Malcolm Purvis [this message]
2008-02-05 0:14 ` Katsumi Yamaoka
2008-02-07 23:44 ` Katsumi Yamaoka
2008-02-08 11:45 ` Malcolm Purvis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wspkq5oz.fsf@xemacs.org \
--to=malcolmp@xemacs.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).