mm-url bugfix

mm-url bugfix

[Jouni K. Seppänen]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Hi,

A trivial bugfix for using curl as the external program with mm-url:


[-- Attachment #2: curl.patch --]
[-- Type: text/x-patch, Size: 1129 bytes --]

Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 7.1421
diff -u -r7.1421 ChangeLog
--- ChangeLog	1 Dec 2006 15:13:19 -0000	7.1421
+++ ChangeLog	2 Dec 2006 07:30:46 -0000
@@ -1,3 +1,8 @@
+2006-12-02  Jouni K. Seppänen  <jks@iki.fi>
+
+	* mm-url.el (mm-url-predefined-programs): Call curl with correct
+	options.
+
 2006-12-01  Lars Magne Ingebrigtsen  <larsi@gnus.org>
 
 	* nnweb.el (nnweb-gmane-create-mapping): Use the article number from
Index: mm-url.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-url.el,v
retrieving revision 7.16
diff -u -r7.16 mm-url.el
--- mm-url.el	24 Jul 2006 10:55:34 -0000	7.16
+++ mm-url.el	2 Dec 2006 07:30:47 -0000
@@ -57,7 +57,7 @@
   '((wget "wget" "--user-agent=mm-url" "-q" "-O" "-")
     (w3m  "w3m" "-dump_source")
     (lynx "lynx" "-source")
-    (curl "curl" "--silent" "--user-agent mm-url" "--location")))
+    (curl "curl" "--silent" "--user-agent" "mm-url" "--location")))
 
 (defcustom mm-url-program
   (cond

[-- Attachment #3: Type: text/plain, Size: 95 bytes --]


Without this change, curl complains:

curl: option --user-agent mm-url: is unknown

-- 
Jouni

Re: mm-url bugfix

[Katsumi Yamaoka]

>>>>> In <m2wt5aoinx.fsf@hella.local> Jouni K. Seppänen wrote:

> A trivial bugfix for using curl as the external program with mm-url:

> -    (curl "curl" "--silent" "--user-agent mm-url" "--location")))
> +    (curl "curl" "--silent" "--user-agent" "mm-url" "--location")))

> Without this change, curl complains:
> curl: option --user-agent mm-url: is unknown

I verified call-process in mm-url-insert-file-contents-external
returns 2 by the old one but returns 0 by the new one.  I've
installed your patch with the flag `(tiny change)' in the v5-10
branch (it will be merged in the trunk).  Thank you.