Gnus development mailing list
 help / color / mirror / Atom feed
* horrid color choices in 5.4.25
@ 1997-03-10 15:04 Karl Kleinpaste
  1997-03-10 17:02 ` Michael Welsh Duggan
                   ` (4 more replies)
  0 siblings, 5 replies; 30+ messages in thread
From: Karl Kleinpaste @ 1997-03-10 15:04 UTC (permalink / raw)


I haven't been watching the ding list for a few days -- too busy and
out of town -- so please take the following with salt as needed.

I upgraded 5.4.15 -> 5.4.25 this morning.  I use a black-on-white
emacs, and the new color selections are _dreadful_.

Notably, please consider:

Item			5.4.15		5.4.25

from content		midnight blue	indianred
subject content		firebrick	firebrick (no change)
header names		dark green	maroon
header content		dark green	indianred4
newsgroups content	indianred	midnight blue

Please observe in 5.4.25 that in, e.g., mail with no "Newsgroups:"
header, the _entire_ header is in some flavor of red...and even with
such a header present, it stays indianred4 unless it's a crosspost to
get the midnight blue.

Do anyone have any idea how annoying an _all-red header_ is?  And how
uninformative it is, compared to the interesting variations present in
the older version?  It all just blurs into a red blob.

What strikes me as particularly gratuitous in this change was that
"from" went from midnight blue to indianred while "newsgroups" went
from indianred to midnight blue.  What was the imagined benefit of
inverting these two?

Below is a diff -u to recover the previous color scheme in the
(background light) case.  I never use a dark background, so I didn't
address that at all.

--karl

--- gnus-5.4.25/gnus-art.el.~1~	Sat Mar  8 20:26:56 1997
+++ gnus-5.4.25/gnus-art.el	Mon Mar 10 09:30:56 1997
@@ -419,13 +419,13 @@
 (defface gnus-header-from-face
   '((((class color)
       (background dark))
      (:foreground "spring green" :bold t :italic t))
     (((class color)
       (background light))
-     (:foreground "indianred" :bold t :italic t))
+     (:foreground "MidnightBlue" :bold t :italic t))
     (t
      (:bold t :italic t)))
   "Face used for displaying from headers."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
@@ -445,39 +445,39 @@
 (defface gnus-header-newsgroups-face
   '((((class color)
       (background dark))
      (:foreground "yellow" :bold t :italic t))
     (((class color)
       (background light))
-     (:foreground "MidnightBlue" :bold t :italic t))
+     (:foreground "indianred" :bold t :italic t))
     (t
      (:bold t :italic t)))
   "Face used for displaying newsgroups headers."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defface gnus-header-name-face
   '((((class color)
       (background dark))
      (:foreground "SeaGreen"))
     (((class color)
       (background light))
-     (:foreground "maroon"))
+     (:foreground "DarkGreen"))
     (t
      (:bold t)))
   "Face used for displaying header names."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defface gnus-header-content-face
   '((((class color)
       (background dark))
      (:foreground "forest green" :italic t))
     (((class color)
       (background light))
-     (:foreground "indianred4" :italic t))
+     (:foreground "DarkGreen" :italic t))
     (t
      (:italic t)))  "Face used for displaying header content."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defcustom gnus-header-face-alist


^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~1997-03-18  7:50 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-03-10 15:04 horrid color choices in 5.4.25 Karl Kleinpaste
1997-03-10 17:02 ` Michael Welsh Duggan
1997-03-10 17:40 ` Hrvoje Niksic
1997-03-10 18:17   ` Steven L Baur
1997-03-10 20:17     ` Hrvoje Niksic
1997-03-10 23:39 ` Stainless Steel Rat
1997-03-11  2:15 ` Danny Siu
1997-03-11  5:04   ` Lars Magne Ingebrigtsen
1997-03-11  5:31     ` David Lebel
1997-03-11 13:06       ` Johan Danielsson
1997-03-11 14:25         ` Robert Bihlmeyer
1997-03-11 14:26         ` Per Abrahamsen
1997-03-11 16:21           ` Lars Magne Ingebrigtsen
1997-03-13  1:20             ` David Moore
1997-03-16 16:57               ` Jason R. Mastaler
1997-03-18  2:55                 ` David Moore
1997-03-11 19:52           ` Dan Schmidt
1997-03-12 16:04             ` Lars Magne Ingebrigtsen
1997-03-14 13:26               ` Robert Bihlmeyer
1997-03-14 19:47                 ` Lars Magne Ingebrigtsen
1997-03-17 11:54                   ` Robert Bihlmeyer
1997-03-17 14:08                     ` Lars Magne Ingebrigtsen
1997-03-17 20:09                       ` David Lebel
1997-03-18  7:50                       ` Wesley Hardaker
1997-03-14 20:22                 ` François Pinard
1997-03-11 14:48         ` François Pinard
1997-03-11 13:56     ` Jon Kvebaek
1997-03-11 14:15     ` Karl Kleinpaste
1997-03-11 14:30     ` James Kanze
1997-03-11  2:23 ` (not so!) " François Pinard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).