Latest XEmacs lossage in sgnus 0.15

Latest XEmacs lossage in sgnus 0.15

[William Perry]

Chokes and dies immediately when gnus-server-mode tries to access the e19
specific variable menu-bar-mode.

It should be enough to just set menu-bar-mode to 't' somewhere, since the
XEmacs menu code is fast enough that it shouldn't matter whether it is
called or not.  I'm not 100% sure where to put the bogus defvar though - I
threw one into gnus-xmas.el just for kicks. Patches below.

Also, several calls to buffer-disable-undo didn't pass in a buffer argument
like XEmacs requires.  Patches below.

-Bill P.

===================================================================
RCS file: gnus-soup.el,v
retrieving revision 1.1
diff -c -r1.1 gnus-soup.el
*** 1.1	1995/11/25 19:08:43
--- gnus-soup.el	1995/11/25 19:08:52
***************
*** 401,407 ****
      (save-excursion
        (set-buffer (find-file-noselect
  		   (concat gnus-soup-directory "AREAS")))
!       (buffer-disable-undo)
        (erase-buffer)
        (let ((areas gnus-soup-areas)
  	    area)
--- 401,407 ----
      (save-excursion
        (set-buffer (find-file-noselect
  		   (concat gnus-soup-directory "AREAS")))
!       (buffer-disable-undo (current-buffer))
        (erase-buffer)
        (let ((areas gnus-soup-areas)
  	    area)
***************
*** 433,439 ****
        (gnus-make-directory dir))
    (save-excursion
      (set-buffer (find-file-noselect (concat dir "REPLIES")))
!     (buffer-disable-undo)
      (erase-buffer)
      (let (area)
        (while areas
--- 433,439 ----
        (gnus-make-directory dir))
    (save-excursion
      (set-buffer (find-file-noselect (concat dir "REPLIES")))
!     (buffer-disable-undo (current-buffer))
      (erase-buffer)
      (let (area)
        (while areas
===================================================================
RCS file: gnus-xmas.el,v
retrieving revision 1.1
diff -c -r1.1 gnus-xmas.el
*** 1.1	1995/11/25 19:09:34
--- gnus-xmas.el	1995/11/25 19:09:43
***************
*** 25,30 ****
--- 25,31 ----
  ;;; Code:
  
  (require 'text-props)
+ (defvar menu-bar-mode t)
  
  (defvar gnus-xmas-glyph-directory nil
    "*Directory where Gnus logos and icons are located.
===================================================================
RCS file: nnsoup.el,v
retrieving revision 1.1
diff -c -r1.1 nnsoup.el
*** 1.1	1995/11/25 19:09:08
--- nnsoup.el	1995/11/25 19:09:14
***************
*** 626,632 ****
  						 (match-end 1))))))))
  	active group lines ident elem min)
      (set-buffer (get-buffer-create " *nnsoup work*"))
!     (buffer-disable-undo)
      (while files
        (message "Doing %s..." (car files))
        (erase-buffer)
--- 626,632 ----
  						 (match-end 1))))))))
  	active group lines ident elem min)
      (set-buffer (get-buffer-create " *nnsoup work*"))
!     (buffer-disable-undo (current-buffer))
      (while files
        (message "Doing %s..." (car files))
        (erase-buffer)
===================================================================
RCS file: nntp.el,v
retrieving revision 1.1
diff -c -r1.1 nntp.el
*** 1.1	1995/11/25 19:09:18
--- nntp.el	1995/11/25 19:09:22
***************
*** 624,630 ****
    (when (file-exists-p "~/.nntp-authinfo")
      (save-excursion
        (set-buffer (get-buffer-create " *authinfo*"))
!       (buffer-disable-undo)
        (erase-buffer)
        (insert-file-contents "~/.nntp-authinfo")
        (goto-char (point-min))
--- 624,630 ----
    (when (file-exists-p "~/.nntp-authinfo")
      (save-excursion
        (set-buffer (get-buffer-create " *authinfo*"))
!       (buffer-disable-undo (current-buffer))
        (erase-buffer)
        (insert-file-contents "~/.nntp-authinfo")
        (goto-char (point-min))

Re: Latest XEmacs lossage in sgnus 0.15

[Steven L. Baur]

These patches are to be applied after William's.

More to come.  Gnus on XEmacs is still broken, but this will at least
allow you to get in and look at your e-mail.

--- gnus.el.orig	Sat Nov 25 13:30:08 1995
+++ gnus.el	Sat Nov 25 13:30:29 1995
@@ -2219,7 +2219,7 @@
 (defun gnus-mouse-face-function (form type)
   `(put-text-property
     (point) (progn ,@form (point))
-    ,gnus-mouse-face-prop 
+    gnus-mouse-face-prop 
     ,(if (equal type 0)
 	 'gnus-mouse-face
        `(quote ,(symbol-value (intern (format "gnus-mouse-face-%d" type)))))))
--- gnus-xmas.el~	Sat Nov 25 12:50:02 1995
+++ gnus-xmas.el	Sat Nov 25 13:29:54 1995
@@ -136,12 +136,12 @@
 	(progn
 	  (setq info (nth 2 entry))
 	  (gnus-group-insert-group-line 
-	   nil group (gnus-info-level info) (gnus-info-marks info)
+	   group (gnus-info-level info) (gnus-info-marks info)
 	   (car entry) (gnus-info-method info)))
       (setq active (gnus-gethash group gnus-active-hashtb))
 	  
       (gnus-group-insert-group-line 
-       nil group (if (member group gnus-zombie-list) gnus-level-zombie
+       group (if (member group gnus-zombie-list) gnus-level-zombie
 		   gnus-level-killed)
        nil (if active (- (1+ (cdr active)) (car active)) 0) nil))
     (save-excursion
@@ -310,7 +310,6 @@
 (defun gnus-xmas-redefine ()
 
 
-  (fset 'gnus-mouse-face-function 'identity)
   (fset 'gnus-summary-make-display-table (lambda () nil))
   (fset 'gnus-visual-turn-off-edit-menu 'identity)
   (fset 'gnus-highlight-selected-summary
@@ -486,6 +485,5 @@
        (gnus-xmas-setup-toolbar gnus-summary-toolbar)
        (set-specifier (symbol-value gnus-use-toolbar)
 		      (cons (current-buffer) gnus-summary-toolbar))))
-
 
 ;;; gnus-xmas.el ends here
--- ChangeLog~	Sat Nov 25 03:13:41 1995
+++ ChangeLog	Sat Nov 25 13:47:31 1995
@@ -1,3 +1,13 @@
+Sat Nov 25 13:41:08 1995  Steven L. Baur  <steve@diana.miranova.com (Steven L. Baur)>
+
+	* gnus.el (gnus-mouse-face-function): One comma too many on
+	gnus-mouse-face-prop
+
+	* gnus-xmas.el (gnus-xmas-redefine): Don't undefine
+	gnus-mouse-face-function.
+	(gnus-xmas-group-insert-group-line-info): Remove now bogus first
+	parameter.
+
 Sat Nov 25 10:55:49 1995  Lars Magne Ingebrigtsen  <larsi@narfi.ifi.uio.no>
 
 	* gnus-topic.el (gnus-topic-mode): Allow not redisplaying.

-- 
steve@miranova.com baur

Re: Latest XEmacs lossage in sgnus 0.15

[Steven L. Baur]

transient-mark-mode is documented to exist on XEmacs 19.13, but does
not.  I guess this makes it a documentation bug.
The fix is trivial.

--- ChangeLog~  Sat Nov 25 13:47:31 1995
+++ ChangeLog   Sat Nov 25 14:24:17 1995
@@ -1,5 +1,10 @@
 Sat Nov 25 13:41:08 1995  Steven L. Baur  <steve@diana.miranova.com (Steven L. Baur)>
 
+       * gnus.el (gnus-group-process-prefix): transient-mark-mode
+       doesn't exist on XEmacs.
+
+       * gnus.el (gnus-summary-work-articles): ditto.
+
        * gnus.el (gnus-mouse-face-function): One comma too many on
        gnus-mouse-face-prop

--- gnus.el~    Sat Nov 25 13:30:29 1995
+++ gnus.el     Sat Nov 25 14:08:05 1995
@@ -4496,7 +4496,7 @@
          (setq n (1- n))
          (gnus-group-next-group way)))
       (nreverse groups)))
-   ((and transient-mark-mode
+   ((and (fboundp 'transient-mark-mode) transient-mark-mode
         mark-active)
     ;; Work on the region between point and mark.
     (let ((max (max (point) (mark)))
@@ -8408,7 +8408,7 @@
                   (gnus-summary-find-next nil article)))
          (decf n)))
       (nreverse articles)))
-   ((and transient-mark-mode
+   ((and (fboundp 'transient-mark-mode) transient-mark-mode
         mark-active)
     ;; Work on the region between point and mark.
     (let ((max (max (point) (mark)))

-- 
steve@miranova.com baur

Re: Latest XEmacs lossage in sgnus 0.15

[William Perry]

Steven L. Baur writes:
> transient-mark-mode is documented to exist on XEmacs 19.13, but does
> not.  I guess this makes it a documentation bug.
> The fix is trivial.

  Just a quick note - the test in there should techinically be 'boundp' not
'fboundp', since you are checking it as a variable.  In some psychotic
instances, someone might have transient-mark-mode defined as a convenience
function in XEmacs, but not use the same variable name for storage.  Just
in case... :)

-Bill P

Re: Latest XEmacs lossage in sgnus 0.15

[Jens Lautenbacher]

There are still some things that don't work.

a) Using `A A' will *not* catch the whole active file (at least if the
   setting of gnus-read-active-file is 'some) I consider this a very
   annoying bug as it leaves you around with only the groups you are
   subscribed to and the list of killed groups (if you have one using
   gnus-group-list-killed. Doing a `C-u A k' of course dosn't cure the
   problem as it also does not fetch the active file)

b) In a listing of all killed or zombie groups the groups are not
   highlighted when the mouse moves over them. After subscribing to
   one (`u'),  highlighting works again.

c) you can not browse a group of the killed list. (new since
   0.15). Error message:
   
   Signalling: (wrong-type-argument stringp nil)
   intern-soft(nil [t-netz\.tv z-netz\.alt\.support\.natascha-binaer 0 0 rec\.crafts\.glass soc\.culture\.malaysia rec\.humor\.oracle alt\.sex\.wanted t-netz\.fractint eunet\.jokes alt\.music\.lou-reed alt\.lycra t-netz\.amiga-gadget\.allgemein soc\.genealogy\.surnames z-netz\.koordination\.diskurs fido\.ger\.sat soc\.culture\.tamil soc\.culture\.iraq comp\.cad\.cadence rec\.food\.sourdough alt\.irc\.bots comp\.sys\.amiga\.uucp list\.win-ip comp\.sys\.tahoe gnu\.gcc vmsnet\.infosystems\.misc 0 cl\.antifa\.diskussion rec\.games\.video\.atari rec\.radio\.amateur\.digital\.misc bit\.listserv\.brs-l 0 alt\.religion\.broadcast list\.miles talk\.politics\.crypto rec\.games\.video\.arcade\.collecting z-netz\.wichtig z-netz\.alt\.pbem\.imperium\.spielsuche comp\.os\.vms misc\.forsale\.computers\.pc-specific\.audio cern\.atari rec\.arts\.tv\.uk\.misc fido\.elektronik_ger 0 alt\.sigma2\.penis fido\.ger\.windows\.prog control\.newgroup cl\.europa\.balkan alt\.tv\.dinosaurs z-netz\.gesun
 dheit\.diskussion ...])
   gnus-adjust-marked-articles(nil)
   gnus-select-newsgroup("alt.aldus.pagemaker" nil)
   gnus-summary-read-group("alt.aldus.pagemaker" nil nil)
   gnus-group-read-group(nil)
   gnus-mouse-pick-group(#<buttondown-event button2>)
   call-interactively(gnus-mouse-pick-group)


d) fetching of old articles still doesn't work anymore (at least 0.12
   to 0.15) with settings: (setq gnus-fetch-old-headers t) and (setq
   gnus-summary-make-false-root 'dummy) This is annoying as it works
   with gnus5.0.12.


Any help or suggestions where to start debugging?

Thanks 
	jens

Re: Latest XEmacs lossage in sgnus 0.15

[Steven L. Baur]

> c) you can not browse a group of the killed list.

I verified that.  Probably related is the new bug (from 0.1[345])
where nnvirtual groups cannot be created.

Adding to your list:  (In no particular order)
The dribble file never gets autosaved (new with 0.13).  The loser with
this one is the erroneous (for XEmacs) (setq buffer-file-name ...)
replacing the valid (set-visited-file-name ...) in
gnus-dribble-read-file.

nnheader-insert-head (used by all the local file routines) exercises
an XEmacs GC bug.  I have a patch for this, but it breaks ange-ftp
stuffs.

Entry to topics mode fails, at least with a gnus-group-topics string
that used to work with 0.14.  Of course, since the text-properties get
screwed up by an XEmacs bug, gnus-topics has never completely worked.

Nnvirtual groups have failed to behave in any reasonable fashion since
0.12.  (Probably some wierd XEmacs problem since they work for Lars).

Pseudo-article/dummy article default format strings do not contain the
necessary magic to have mouse highlight enabled.

> Any help or suggestions where to start debugging?

The easiest would be problems introduced since 5.0.12.  The lack of
highlighting you described in b) might be the most rewarding.  I smell
an XEmacs bug there (I've noticed analogous behavior from time to
time in other places), but cannot as yet prove it.

-- 
steve@miranova.com baur