From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: ding@gnus.org
Subject: Re: a bug with gnus-summary-refer-article?
Date: Wed, 13 Jan 2016 15:01:03 +0100 [thread overview]
Message-ID: <m2ziw9o9y8.fsf@charm-ecran.irisa.fr> (raw)
In-Reply-To: <m24mehpy43.fsf@charm-ecran.irisa.fr> (Alan Schmitt's message of "Wed, 13 Jan 2016 11:33:48 +0100")
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On 2016-01-13 11:33, Alan Schmitt <alan.schmitt@polytechnique.org> writes:
> The `gnus-request-update-mark' function works well for nnimap (as there
> is no corresponding function, so the initial mark is returned), but it
> seems to be problematic with nnir. I cannot edebug it further because
> `nnir-request-update-mark' is a deffoo, and I don’t know how to debug
> those.
Using the lisp debugger I think I’ve found the crux of the problem, the
function `nnir-request-update-mark' from nnir.el returns nil when the
article number is negative. I see two way to solve the issue:
- return the original mark when the article is a negative number (which
is basically what nnimap does)
The code would then be this:
#+begin_src emacs-lisp
(deffoo nnir-request-update-mark (group article mark)
(let ((artgroup (nnir-article-group article))
(artnumber (nnir-article-number article)))
(if (and artgroup artnumber)
(gnus-request-update-mark artgroup artnumber mark)
mark)))
#+end_src
- allow the call to `gnus-request-update-mark' to return nil, but then
protect the remainder of the code in that case
I’ll update the bug report with this information.
Thoughts?
Alan
--
OpenPGP Key ID : 040D0A3B4ED2E5C7
Athmospheric CO₂ (Updated January 12, 2016, Mauna Loa Obs.): 401.82 ppm
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
prev parent reply other threads:[~2016-01-13 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 21:21 Alan Schmitt
2016-01-12 8:00 ` Alan Schmitt
2016-01-13 0:50 ` Katsumi Yamaoka
2016-01-13 8:49 ` Alan Schmitt
2016-01-13 9:10 ` Katsumi Yamaoka
2016-01-13 9:30 ` Katsumi Yamaoka
2016-01-13 10:33 ` Alan Schmitt
2016-01-13 14:01 ` Alan Schmitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ziw9o9y8.fsf@charm-ecran.irisa.fr \
--to=alan.schmitt@polytechnique.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).