From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/15363
Path: main.gmane.org!not-for-mail
From: SL Baur <steve@vmailer.xemacs.org>
Newsgroups: gmane.emacs.gnus.general
Subject: [PATCH] Another gnus-topics parameter bug
Date: 23 Jun 1998 21:36:42 -0700
Sender: owner-ding@hpc.uh.edu
Message-ID: <m2zpf3e7qd.fsf@altair.xemacs.org>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0 (generated by tm-edit 7.108)
Content-Type: text/plain; charset=US-ASCII
X-Trace: main.gmane.org 1035154408 21720 80.91.224.250 (20 Oct 2002 22:53:28 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 20 Oct 2002 22:53:28 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from gwyn.tux.org (gwyn.tux.org [207.96.122.8])
	by altair.xemacs.org (8.9.0/8.9.0) with ESMTP id VAA14537
	for <steve@altair.xemacs.org>; Tue, 23 Jun 1998 21:42:46 -0700
Original-Received: from gizmo.hpc.uh.edu (gizmo.hpc.uh.edu [129.7.102.31])
	by gwyn.tux.org (8.8.8/8.8.8) with ESMTP id AAA11545
	for <steve@xemacs.org>; Wed, 24 Jun 1998 00:38:29 -0400
Original-Received: from sina.hpc.uh.edu (sina.hpc.uh.edu [129.7.3.5]) by gizmo.hpc.uh.edu (8.7.6/8.7.3) with ESMTP id XAS08312; Tue, 23 Jun 1998 23:08:31 -0500
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 23 Jun 1998 23:33:07 -0500 (CDT)
Original-Received: from claymore.vcinet.com (claymore.vcinet.com [208.205.12.23]) by sina.hpc.uh.edu (8.7.3/8.7.3) with SMTP id XAA16544 for <ding@hpc.uh.edu>; Tue, 23 Jun 1998 23:32:59 -0500 (CDT)
Original-Received: (qmail 21617 invoked by uid 504); 24 Jun 1998 04:32:36 -0000
Original-Received: (qmail 21614 invoked from network); 24 Jun 1998 04:32:35 -0000
Original-Received: from vmailer.xemacs.org (vmailer@206.190.83.63)
  by claymore.vcinet.com with SMTP; 24 Jun 1998 04:32:35 -0000
Original-Received: from altair.xemacs.org (vmailer.xemacs.org 206.190.83.63)
	by vmailer.xemacs.org (VMailer) via SMTP
	id 309D8AAF15; Tue, 23 Jun 1998 21:36:43 -0700 (PDT)
Mail-Copies-To: never
Original-To: ding@gnus.org
X-Face: (:YAD@JS'&Kz'M}n7eX7gEvPR6U1mJ-kt;asEc2qAv;h{Yw7ckz<7+X_SYeTNAaPui:e~x$
 ,A=gkt*>UPL/}\a/#C~v2%ETiAY_sx;xve0yL??JWTtX_-NUzXyP38UdW#cmN1\4(X!c3m#%IbtB-3
 Z-!xpZi!`E.s{(;aP=b11"!3wQu]1j@^V|;n=B|{l<bZV1.AI`zWV%kPCnUhcgEe\(}/_kNd6,*3ZJ
 Q3o<YQ3^u;7jS=:p0--u3msQO
X-Attribution: sb
Original-Lines: 48
X-Mailer: Gnus v5.6.12/XEmacs 21.0 - "Uzbek Black"
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:15363
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:15363

The nconc is operating on the actual group parameters, thus if there
happens to exist any topic parameters, they will get spliced directly
into the group parameters.  This is unintuitive at best.

Reproduce this by creating a dummy topic and a dummy group in the
topic.

Add parameters to the group:  ((visible . t) (comment . "blah"))

Add parameters to the topic: ((expiry-wait . 14))

M-: (gnus-group-topic-parameters "nnml:dummy")

Now reedit the group parameters from the topics buffer to see:

((visible . t) (comment . "blah") (expiry-wait . 14))


This patch *replaces* the one I posted a few minutes ago.

1998-06-23  SL Baur  <steve@altair.xemacs.org>

	* gnus-topic.el (gnus-group-topic-parameters): Remove nesting
	around group-specific parameters.
	Use append instead of nconc since we have a pointer to the
	actual group parameters.

===================================================================
RCS file: RCS/gnus-topic.el,v
retrieving revision 1.4
diff -u -r1.4 gnus-topic.el
--- gnus-topic.el	1998/06/24 04:31:14	1.4
+++ gnus-topic.el	1998/06/24 04:31:45
@@ -326,11 +326,11 @@
 
 (defun gnus-group-topic-parameters (group)
   "Compute the group parameters for GROUP taking into account inheritance from topics."
-  (let ((params-list (list (gnus-group-get-parameter group))))
+  (let ((params-list (gnus-group-get-parameter group)))
     (save-excursion
       (gnus-group-goto-group group)
-      (nconc params-list
-	     (gnus-topic-hierarchical-parameters (gnus-current-topic))))))
+      (append params-list
+	      (gnus-topic-hierarchical-parameters (gnus-current-topic))))))
 
 (defun gnus-topic-hierarchical-parameters (topic)
   "Return a topic list computed for TOPIC."