Re: bug in latest gnus when previewing certain message

[Jesper Harder <harder@myrealbox.com>]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Simon Josefsson <jas@extundo.com> writes:

> "Vladimir Volovich" <vvv@vsu.ru> writes:
>
>> using the latest gnus from cvs, i get the following error when trying to
>> view the attached (spam) message:
>>
>> Debugger entered--Lisp error: (args-out-of-range 650 650)
>>   mm-decode-coding-region(650 650 koi8-r)
>>   mail-decode-encoded-word-region(1 883)
>
> This seems to fix it, but someone familiar with rfc2047.el better check.

I think this change is the culprit:

,----
| 2003-05-02  Dave Love  <fx@gnu.org>
| 
| 	* rfc2047.el (rfc2047-q-encode-region, rfc2047-decode): Use
| 	mm-with-unibyte-current-buffer.
`----

I.e. `mm-with-unibyte-current-buffer-mule4' was changed to
`mm-with-unibyte-current-buffer' which isn't equivalent -- the latter
makes the current buffer unibyte which the former doesn't in Mule > 4.

This patch fixes it.  But I never understood what the mule4 stuff was
about, so it might break on Emacsen that use that.  

Which Emacs versions use Mule version 4, by the way?  Maybe we don't
need to support it anymore?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rfc2047.el.diff --]
[-- Type: text/x-patch, Size: 1039 bytes --]

--- gnus/lisp/rfc2047.el	Wed May 21 16:53:23 2003
+++ rfc2047.el	Mon May 26 19:18:06 2003
@@ -697,18 +697,17 @@
 		 mail-parse-charset)
 	(setq cs mail-parse-charset))
       ;; Fixme: What's this for?  The following comment makes no sense. -- fx
-      (mm-with-unibyte-current-buffer
-	;; In Emacs Mule 4, decoding UTF-8 should be in unibyte mode.
-	(mm-decode-coding-string
-	 (cond
-	  ((equal "B" encoding)
-	   (base64-decode-string
-	    (rfc2047-pad-base64 string)))
-	  ((equal "Q" encoding)
-	   (quoted-printable-decode-string
-	    (mm-replace-chars-in-string string ?_ ? )))
-	  (t (error "Invalid encoding: %s" encoding)))
-	 cs)))))
+      ;; In Emacs Mule 4, decoding UTF-8 should be in unibyte mode.
+      (mm-decode-coding-string
+       (cond
+	((equal "B" encoding)
+	 (base64-decode-string
+	  (rfc2047-pad-base64 string)))
+	((equal "Q" encoding)
+	 (quoted-printable-decode-string
+	  (mm-replace-chars-in-string string ?_ ? )))
+	(t (error "Invalid encoding: %s" encoding)))
+       cs))))
 
 (provide 'rfc2047)