From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/51294
Path: main.gmane.org!not-for-mail
From: Jesper Harder <harder@myrealbox.com>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: [PATCH] Skip over citations and signature (resend)
Date: Thu, 10 Apr 2003 02:06:12 +0200
Organization: http://purl.org/harder/
Sender: owner-ding@hpc.uh.edu
Message-ID: <m34r572p3f.fsf@defun.localdomain>
References: <87smuvh2gm.fsf@mulligatwani.msrl.com> <87n0l1759d.fsf@mulligatwani.msrl.com>
 <m3fzor5ovz.fsf@defun.localdomain> <87k7e3jlv7.fsf@mulligatwani.msrl.com>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1049933368 25815 80.91.224.249 (10 Apr 2003 00:09:28 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Thu, 10 Apr 2003 00:09:28 +0000 (UTC)
Original-X-From: owner-ding@hpc.uh.edu Thu Apr 10 02:09:24 2003
Return-path: <owner-ding@hpc.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 193Pd5-0006he-00
	for <ding-account@gmane.org>; Thu, 10 Apr 2003 02:09:24 +0200
Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 193PcW-0005FU-00; Wed, 09 Apr 2003 19:08:48 -0500
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 09 Apr 2003 19:09:53 -0500 (CDT)
Original-Received: from sclp3.sclp.com (sclp3.sclp.com [64.157.176.121])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id TAA09285
	for <ding@hpc.uh.edu>; Wed, 9 Apr 2003 19:09:41 -0500 (CDT)
Original-Received: (qmail 57460 invoked by alias); 10 Apr 2003 00:08:31 -0000
Original-Received: (qmail 57455 invoked from network); 10 Apr 2003 00:08:31 -0000
Original-Received: from quimby.gnus.org (80.91.224.244)
  by gnus.org with SMTP; 10 Apr 2003 00:08:31 -0000
Original-Received: from news by quimby.gnus.org with local (Exim 3.12 #1 (Debian))
	id 193PgR-0000V6-00
	for <ding@gnus.org>; Thu, 10 Apr 2003 02:12:51 +0200
Original-To: ding@gnus.org
Original-Path: localhost.localdomain!nobody
Original-Newsgroups: gnus.ding
Original-Lines: 31
Original-NNTP-Posting-Host: 0xc3f98233.esnxr3.ras.tele.dk
Original-X-Trace: quimby.gnus.org 1049933571 1927 195.249.130.51 (10 Apr 2003 00:12:51 GMT)
Original-X-Complaints-To: usenet@quimby.gnus.org
Original-NNTP-Posting-Date: 10 Apr 2003 00:12:51 GMT
X-Face: ^RrvqCr7c,P$zTR:QED"@h9+BTm-"fjZJJ-3=OU7.)i/K]<.J88}s>'Z_$r;<N5ksn~%wJ@2pjF}="tV;FBsdpFarSWA<oYkZsViGf:F^SD-KXhvFxh;~]?)SWm~+u};0=x}<vOm&5J+?]yB2d]q4x8\0g7SX
Mail-Copies-To: never
User-Agent: Gnus/5.090018 (Oort Gnus v0.18) Emacs/21.3.50 (gnu/linux)
Cancel-Lock: sha1:XKyQVoHH0fiB6nacCFnEhHvVPfA=
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:51294
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:51294

Michael Shields <shields@msrl.com> writes:

> Jesper Harder <harder@myrealbox.com> wrote:
>>> 2003-02-12  Michael Shields  <shields@msrl.com>
>>>
>>> 	* gnus-sum.el (gnus-article-goto-next-page,
>>> 	gnus-article-goto-prev-page): Call gnus-summary-*-page, instead of
>>> 	relying on the summary bindings of `n' and `p'.
>>
>> Michael, could you check if it's really required -- this change breaks
>> gnus-pick-mode.
>
> In what way does it break?  It looks to me that gnus-pick-mode does not
> change the bindings of `n' or `p'; they are not in gnus-pick-mode-map.

It displays the summary buffer.  The point of pick-mode is that you only
want to see the article buffer after selecting the articles to read.

There's also some code in `gnus-article-read-summary-keys' that appears
to deal with pick-mode specially -- stuff like

   (let (gnus-pick-mode)

I'm not sure exactly what the purpose is :-)

I also get an error after reading the last selected article and exiting
the group

gnus-article-goto-next-page: Wrong type argument: window-live-p,#<window 3>

Both problems disappear after reverting the patch.