0.79 nnmail-spool-file 'directory read error (patch included)

0.79 nnmail-spool-file 'directory read error (patch included)

[Jari Aalto+mail.emacs]

    Downloaded latest 0.79 and wondered why command

        my-gnus-group-get-new-news-this-group

    No more read the nnml procmail spool files. I chased it to the wrong 
    regexp definition in nnmail::mail-source-fetch. Since the files all have
    suffix ".spool"  the regexp never matches due to extra "$".

     (setq-default nnmail-spool-file
	    (list
	     (list 'file ':path  (getenv "MAIL"))
	     (list 'directory ':path  spool ':suffix ".spool")  ;; .prcml
	     ))

    The problem crystalized in mail-source-fetch-directory.

    jari

      (dolist (file (directory-files
		     path t (concat (regexp-quote suffix) "$")))

>> already filters .spool

	(d!! (file-name-nondirectory file) 
	     predicate
	     callback
	     "\n\n"
	     )
	(when (and (file-regular-p file)
		   (funcall predicate file)

>> but this will never accept file mail.default.spool

		   (mail-source-movemail file mail-source-crash-box))
	  (incf found (mail-source-callback callback file))))
      found)))



--- nnmail.el.orig	Sun Feb 28 16:36:36 1999
+++ nnmail.el	Sun Feb 28 16:36:47 1999
@@ -1379,8 +1379,8 @@
 	  (setq source (append source
 			       (list :predicate
 				     `(lambda (file)
-					(string-match 
-                                         ,(concat (regexp-quote group) "$")
+					(string-match
+                                         ,(concat (regexp-quote group) )
                                          file))))))
 	(when nnmail-fetched-sources
 	  (if (member source nnmail-fetched-sources)

Re: 0.79 nnmail-spool-file 'directory read error (patch included)

[Lars Magne Ingebrigtsen]

jari.aalto@poboxes.com (Jari Aalto+mail.emacs) writes:

>       (dolist (file (directory-files
> 		     path t (concat (regexp-quote suffix) "$")))
> 
> >> already filters .spool

Yes...

> 
> 	(d!! (file-name-nondirectory file) 
> 	     predicate
> 	     callback
> 	     "\n\n"
> 	     )

Hm?  I can't find this in the sources...

> 	(when (and (file-regular-p file)
> 		   (funcall predicate file)
> 
> >> but this will never accept file mail.default.spool

I don't see why not.  The predicate is either `identity' or

                                   `(lambda (file)
				     (string-match 
				      ,(concat
					(regexp-quote (concat group suffix)) 
					"$")
				      file))

And if the group is "mail.default" and the suffix is ".spool", then
that predicate should return non-nil.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen