Re: High uid breaks (message-unique-id)

[Bjorn Solberg <bjorn_ding1@hekneby.org>]

Simon Josefsson writes:

> Bjorn Solberg <bjorn_ding1@hekneby.org> writes:
>> I recently was handed an iMac (G5) to use:
>> 
>> # uname -a
>> Darwin szbsolberg 8.4.0 Darwin Kernel Version 8.4.0: Tue Jan  3 18:22:10 PST 2006; root:xnu-792.6.56.obj~1/RELEASE_PPC Power Macintosh powerpc
>> $ id
>> uid=2108389971(bsolberg) gid=814917730(OFFICE\domain users) groups=814917730(OFFICE\domain users), 81(appserveradm), 79(appserverusr), 80(admin)
>> 
>> and noticed that Gnus wouldn't let me reply to messages.  A little
>> research lead to this patch:
>> 
>> # diff message.el-7.122 message.el
>> 4770c4770
>> <      (if (memq system-type '(ms-dos emx vax-vms))
>> ---
>>> (if (memq system-type '(ms-dos emx vax-vms darwin))
>> 
>> The reason is that (user-uid) returns 2108389971.0 which is not an
>> integer which causes trouble in (message-number-base36 ()).  The number
>> is too high to be truncated to an integer.  I though about dividing by
>> some number until the value became low enough to be interpreted as an
>> integer, but decided to skip the whole issue by the above patch.  (This
>> is running in CVS GNU Emacs.)
>> 
>> It works well for me, but those in the know of the details and
>> surrounding issues of this may have a better way to deal with it.

> How about this?  It may be more general.

> --- message.el	01 Feb 2006 12:36:39 +0100	7.122
> +++ message.el	05 Feb 2006 19:43:57 +0100	
> @@ -4767,7 +4767,9 @@
>  	   (* 25 25)))
>    (let ((tm (current-time)))
>      (concat
> -     (if (memq system-type '(ms-dos emx vax-vms))
> +     (if (or (memq system-type '(ms-dos emx vax-vms))
> +	     ;; message-number-base36 doesn't handle bigints.
> +	     (float (user-uid)))
>  	 (let ((user (downcase (user-login-name))))
>  	   (while (string-match "[^a-z0-9_]" user)
>  	     (aset user (match-beginning 0) ?_))

This patch has worked well for me for a month now.  I haven't seen it
make it into CVS though - shouldn't it go there?

Bjorn.