Gnus development mailing list
 help / color / mirror / Atom feed
* bug? message.el `message-setup-1' mail-header-separator read-only
@ 2004-04-28 12:37 Karl Chen
  2004-04-28 14:05 ` bug? message.el `message-setup-1' mail-header-separator Jesper Harder
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Chen @ 2004-04-28 12:37 UTC (permalink / raw)



Is the mail-header-separator text inserted by `message-setup-1'
supposed to be read-only?  It makes sense for it to be so, and the
code actually sets it to NOT read-only, which seems useless since
it would by default be read-only.

The one-line patch below fixes it.



diff -u /var/tmp/quarl/pkg/Gnus/gnus-5.10.6/lisp/message.el /tmp/buffer-content-12964U1r
--- /var/tmp/quarl/pkg/Gnus/gnus-5.10.6/lisp/message.el	2004-04-28 05:35:45.000000000 -0700
+++ /tmp/buffer-content-12964U1r	2004-04-28 05:35:48.000000000 -0700
@@ -5465,7 +5465,7 @@
    (progn
      (insert mail-header-separator "\n")
      (1- (point)))
-   'read-only nil)
+   'read-only t)
   (forward-line -1)
   (when (message-news-p)
     (when message-default-news-headers



-- 
Karl 2004-04-28 05:29



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: bug? message.el `message-setup-1' mail-header-separator
  2004-04-28 12:37 bug? message.el `message-setup-1' mail-header-separator read-only Karl Chen
@ 2004-04-28 14:05 ` Jesper Harder
  0 siblings, 0 replies; 2+ messages in thread
From: Jesper Harder @ 2004-04-28 14:05 UTC (permalink / raw)


Karl Chen <quarl@hkn.eecs.berkeley.edu> writes:

> Is the mail-header-separator text inserted by `message-setup-1'
> supposed to be read-only?

No, I don't think so.  It breaks various stuff if you make it
read-only.

> It makes sense for it to be so, and the code actually sets it to NOT
> read-only, which seems useless since it would by default be
> read-only.

Yeah, that code appears to be completely redundant.

-- 
Jesper Harder                                <http://purl.org/harder/>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-28 14:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-04-28 12:37 bug? message.el `message-setup-1' mail-header-separator read-only Karl Chen
2004-04-28 14:05 ` bug? message.el `message-setup-1' mail-header-separator Jesper Harder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).