* Re: Changes committed gnus/lisp (ChangeLog md4.el ntlm.el [not found] <E1AdJEw-00083u-00@quimby.gnus.org> @ 2004-01-05 1:23 ` Jesper Harder 2004-01-05 1:27 ` Lars Magne Ingebrigtsen 2004-01-05 1:49 ` Simon Josefsson 0 siblings, 2 replies; 3+ messages in thread From: Jesper Harder @ 2004-01-05 1:23 UTC (permalink / raw) "Simon Josefsson" <simon@josefsson.org> writes: > Added: md4.el ntlm.el sasl-ntlm.el > > +(defun print-int32 (int32) > + > +(defun print-string-hexa (str) [... and more similar examples]. I think this is dangerous -- md4.el shouldn't define symbols outside its package prefix (`md4-'). ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Changes committed gnus/lisp (ChangeLog md4.el ntlm.el 2004-01-05 1:23 ` Changes committed gnus/lisp (ChangeLog md4.el ntlm.el Jesper Harder @ 2004-01-05 1:27 ` Lars Magne Ingebrigtsen 2004-01-05 1:49 ` Simon Josefsson 1 sibling, 0 replies; 3+ messages in thread From: Lars Magne Ingebrigtsen @ 2004-01-05 1:27 UTC (permalink / raw) Jesper Harder <harder@myrealbox.com> writes: > I think this is dangerous -- md4.el shouldn't define symbols outside > its package prefix (`md4-'). Yup. -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Changes committed gnus/lisp (ChangeLog md4.el ntlm.el 2004-01-05 1:23 ` Changes committed gnus/lisp (ChangeLog md4.el ntlm.el Jesper Harder 2004-01-05 1:27 ` Lars Magne Ingebrigtsen @ 2004-01-05 1:49 ` Simon Josefsson 1 sibling, 0 replies; 3+ messages in thread From: Simon Josefsson @ 2004-01-05 1:49 UTC (permalink / raw) Jesper Harder <harder@myrealbox.com> writes: > "Simon Josefsson" <simon@josefsson.org> writes: > >> Added: md4.el ntlm.el sasl-ntlm.el >> >> +(defun print-int32 (int32) >> + >> +(defun print-string-hexa (str) > > [... and more similar examples]. > > I think this is dangerous -- md4.el shouldn't define symbols outside > its package prefix (`md4-'). Thanks, I fixed those two and ntlm.el. Are there more? (I'm sending the patch to the author and FLIM team.) ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-05 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1AdJEw-00083u-00@quimby.gnus.org>
2004-01-05 1:23 ` Changes committed gnus/lisp (ChangeLog md4.el ntlm.el Jesper Harder
2004-01-05 1:27 ` Lars Magne Ingebrigtsen
2004-01-05 1:49 ` Simon Josefsson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).