Re: Charset encoding brokenness

[Jesper Harder <harder@ifa.au.dk>]

Simon Josefsson <jas@extundo.com> writes:

> Jesper Harder <harder@ifa.au.dk> writes:
>
>> Charset encoding is currently broken in quite a few places, viz.
>>
>> · Forwarding.  `C-u N C-c C-f' for N=1,2,4 is broken if the CTE of
>>   the forwarded message is 8bit.
>
> I believe I fixed N=1 before,

Yup.

> but cannot find any problem with N=4?

He, you had me really confused for a moment -- I was sure that N=4
didn't work.

You're right that N=4 "works" now, but that's because there's a bug in
the logic of `message-forward-make-body', i.e. that N=1 and N=4 do
exactly the same thing.

In both cases `message-forward-make-body-plain' is called, which is
wrong for N=4 where the message isn't supposed to be converted to MML.

> <#part type=message/rfc822 disposition=inline raw=t buffer=" *Original Article*">
> <#/part>
>
> although one has to be careful so the buffer isn't modified between
> when you press C-c C-f and when you post the message.  So it should
> create a new buffer and copy gnus-original-article-buffer there,
> instead of referncing g-o-a-b directly.  Perhaps that buffer even
> should be marked read-only, because if you add a some non-ASCII text
> you will likely break the message, since it is not MIME encoded, which
> novices might not realize (and experts know how to disable the
> read-only flag).  What do you think?

I think it sounds like a good plan.