From: Nevin Kapur <nevin@jhu.edu>
Subject: Re: [PATCH] Re: nnimap: error/warning while trying to quit group
Date: Tue, 17 Sep 2002 16:31:23 -0400 [thread overview]
Message-ID: <m37khk9y2j.fsf@fermat.mts.jhu.edu> (raw)
In-Reply-To: <iluelbsdi9k.fsf@latte.josefsson.org>
Simon Josefsson <jas@extundo.com> writes:
> It looks fine, thanks. A code cleanup seems to be in order though, can
> you test this patch? (On some unimportant groups, preferably.)
>
> 2002-09-17 Simon Josefsson <jas@extundo.com>
It generates an error. Here's *imap-log*:
2861 UID SEARCH UID 1460:1784,1786:2440,2442:2520,2522:2556,2558:2566 NOT SINCE 17-Aug-2002
* SEARCH
2861 OK UID SEARCH completed
2862 UID STORE +FLAGS (\Deleted)
2862 BAD Missing or invalid argument to UID STORE
2863 EXPUNGE
2863 OK No messages deleted, so no update needed
Making the flag addition conditional too fixed the error for me. With
the fix, I tested it on a group and expiry happened as expected:
Index: nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 6.40
diff -u -r6.40 nnimap.el
--- nnimap.el 2002/09/17 20:27:21 6.40
+++ nnimap.el 2002/09/17 21:09:09
@@ -1322,11 +1322,11 @@
(concat "UID "
(imap-range-to-message-set artseq)))))
(when oldarts
- (nnimap-expiry-target oldarts group server))
- (when (imap-message-flags-add
- (imap-range-to-message-set oldarts) "\\Deleted")
- (setq articles (gnus-set-difference
- articles oldarts)))))
+ (nnimap-expiry-target oldarts group server)
+ (when (imap-message-flags-add
+ (imap-range-to-message-set oldarts) "\\Deleted")
+ (setq articles (gnus-set-difference
+ articles oldarts))))))
((numberp days)
(let ((oldarts (imap-search
(format nnimap-expunge-search-string
@@ -1335,11 +1335,11 @@
(imap-fetch-data-hook
'(nnimap-request-expire-articles-progress)))
(when oldarts
- (nnimap-expiry-target oldarts group server))
- (when (imap-message-flags-add
- (imap-range-to-message-set oldarts) "\\Deleted")
- (setq articles (gnus-set-difference
- articles oldarts))))))))))
+ (nnimap-expiry-target oldarts group server)
+ (when (imap-message-flags-add
+ (imap-range-to-message-set oldarts) "\\Deleted")
+ (setq articles (gnus-set-difference
+ articles oldarts)))))))))))
;; return articles not deleted
articles)
next prev parent reply other threads:[~2002-09-17 20:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-16 13:54 Nevin Kapur
2002-09-16 15:39 ` [PATCH] " Nevin Kapur
2002-09-17 10:26 ` Simon Josefsson
2002-09-17 20:31 ` Nevin Kapur [this message]
2002-09-18 9:53 ` Simon Josefsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37khk9y2j.fsf@fermat.mts.jhu.edu \
--to=nevin@jhu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).