From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/46599 Path: main.gmane.org!not-for-mail From: Nevin Kapur Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Re: nnimap: error/warning while trying to quit group Date: Tue, 17 Sep 2002 16:31:23 -0400 Organization: Mathematical Sciences, The Johns Hopkins University Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1032294843 17976 127.0.0.1 (17 Sep 2002 20:34:03 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 17 Sep 2002 20:34:03 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17rP2l-0004f9-00 for ; Tue, 17 Sep 2002 22:33:59 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 17rP0s-00047G-00; Tue, 17 Sep 2002 15:32:02 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 17 Sep 2002 15:32:40 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id PAA26471 for ; Tue, 17 Sep 2002 15:32:21 -0500 (CDT) Original-Received: (qmail 24882 invoked by alias); 17 Sep 2002 20:31:36 -0000 Original-Received: (qmail 24877 invoked from network); 17 Sep 2002 20:31:34 -0000 Original-Received: from main.gmane.org (80.91.224.249) by gnus.org with SMTP; 17 Sep 2002 20:31:34 -0000 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 17rOzw-0004XM-00 for ; Tue, 17 Sep 2002 22:31:04 +0200 Original-To: ding@gnus.org X-Injected-Via-Gmane: http://gmane.org/ Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 17rOzv-0004X9-00 for ; Tue, 17 Sep 2002 22:31:03 +0200 Original-Path: not-for-mail Original-Lines: 63 Original-NNTP-Posting-Host: fermat.mts.jhu.edu Original-X-Trace: main.gmane.org 1032294662 16832 128.220.17.18 (17 Sep 2002 20:31:02 GMT) Original-X-Complaints-To: usenet@main.gmane.org Original-NNTP-Posting-Date: Tue, 17 Sep 2002 20:31:02 +0000 (UTC) X-Face: #i!d%y+1tilG}1ua9z&9waMLqE>H+;pUwWFetZe]4uWiv;VE:GHLnT1\Gj]>l^(]R#}sD@E"(@?vMv,yb@`?32;i~D$6x6m*%!3gPyp-rb$}.%QpxZ!3Y+jESN5[s7SL_68Sc`Aek)A$M|h++b/2VjR.k+Tw4X+0a%:K-kcUeMZ(rs?}v\eG({5J&IPS Mail-Copies-To: never User-Agent: Gnus/5.090008 (Oort Gnus v0.08) XEmacs/21.4 (Informed Management, i686-pc-linux) Cancel-Lock: sha1:cW5i9ktZvtD7ulUv+hOBHzKOsOI= Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:46599 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:46599 Simon Josefsson writes: > It looks fine, thanks. A code cleanup seems to be in order though, can > you test this patch? (On some unimportant groups, preferably.) > > 2002-09-17 Simon Josefsson It generates an error. Here's *imap-log*: 2861 UID SEARCH UID 1460:1784,1786:2440,2442:2520,2522:2556,2558:2566 NOT SINCE 17-Aug-2002 * SEARCH 2861 OK UID SEARCH completed 2862 UID STORE +FLAGS (\Deleted) 2862 BAD Missing or invalid argument to UID STORE 2863 EXPUNGE 2863 OK No messages deleted, so no update needed Making the flag addition conditional too fixed the error for me. With the fix, I tested it on a group and expiry happened as expected: Index: nnimap.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v retrieving revision 6.40 diff -u -r6.40 nnimap.el --- nnimap.el 2002/09/17 20:27:21 6.40 +++ nnimap.el 2002/09/17 21:09:09 @@ -1322,11 +1322,11 @@ (concat "UID " (imap-range-to-message-set artseq))))) (when oldarts - (nnimap-expiry-target oldarts group server)) - (when (imap-message-flags-add - (imap-range-to-message-set oldarts) "\\Deleted") - (setq articles (gnus-set-difference - articles oldarts))))) + (nnimap-expiry-target oldarts group server) + (when (imap-message-flags-add + (imap-range-to-message-set oldarts) "\\Deleted") + (setq articles (gnus-set-difference + articles oldarts)))))) ((numberp days) (let ((oldarts (imap-search (format nnimap-expunge-search-string @@ -1335,11 +1335,11 @@ (imap-fetch-data-hook '(nnimap-request-expire-articles-progress))) (when oldarts - (nnimap-expiry-target oldarts group server)) - (when (imap-message-flags-add - (imap-range-to-message-set oldarts) "\\Deleted") - (setq articles (gnus-set-difference - articles oldarts)))))))))) + (nnimap-expiry-target oldarts group server) + (when (imap-message-flags-add + (imap-range-to-message-set oldarts) "\\Deleted") + (setq articles (gnus-set-difference + articles oldarts))))))))))) ;; return articles not deleted articles)