[patch] 0.37 gnus-article-edit-article fix

[patch] 0.37 gnus-article-edit-article fix

[jari.aalto]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]



    I received a PGP message, hwere gnus buttons were added in the middle of
    PGP block:

        noRr110XVahfo/3MaLL2PGlJ/h8rOdZkJCPCQ1OO8BKcXg3NQWTb+RpqSbSRnbEq
        [...]
        win0apLYccO+tqhhzK3CIiDbgBGfQLNU9ju+nMOOm1VUfF2A/phMoQg6ucYrXFxk

    But I was suprised when I entered edit mode that the buttons were
    still there. I would have expected that gnus-original-article-buffer
    were offered for me to edit

    This patch copies gnus-original-article-buffer to the edit
    buffer so that used really edits the original content.

    jari


[-- Attachment #2: gnus-art.el.diff --]
[-- Type: application/octet-stream, Size: 937 bytes --]

Prereq: 1.37

===================================================================
RCS file: RCS/gnus-art.el,v
retrieving revision 1.37
retrieving revision 1.38
diff -ubw -r1.37 -r1.38
--- 1.37	1998/03/19 08:21:51
+++ 1.38	1998/03/19 08:41:53
@@ -2620,6 +2620,14 @@
   (let ((winconf (current-window-configuration)))
     (set-buffer gnus-article-buffer)
     (gnus-article-edit-mode)
+    ;;
+    ;;  Give user the original article for editing. This
+    ;;  *Article* buffer may have been formatted by variaous gnus functions.
+    ;;
+    (delete-region (point-min) (point-max))
+    (unless (buffer-live-p (get-buffer gnus-original-article-buffer))
+      (error "Can't find orginal buffer: %s" gnus-original-article-buffer))
+    (insert-buffer gnus-original-article-buffer)
     (gnus-set-text-properties (point-min) (point-max) nil)
     (gnus-configure-windows 'edit-article)
     (setq gnus-article-edit-done-function exit-func)

Re: [patch] 0.37 gnus-article-edit-article fix

[Lars Magne Ingebrigtsen]

<jari.aalto@poboxes.com> writes:

>     But I was suprised when I entered edit mode that the buttons were
>     still there. I would have expected that gnus-original-article-buffer
>     were offered for me to edit

Well, I don't think so.  If you want that, hit `C-u g' before editing.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [patch] 0.37 gnus-article-edit-article fix

[jari.aalto]

| 98-03-19 Lars Magne Ingebrigtsen <larsi@gnus.org> list.ding
| <jari.aalto@poboxes.com> writes:
| 
| >     But I was suprised when I entered edit mode that the buttons were
| >     still there. I would have expected that gnus-original-article-buffer
| >     were offered for me to edit
| 
| Well, I don't think so.  If you want that, hit `C-u g' before editing.

Ehm, doesn't edit mean "edit the original article" after all that's
written back to disk (no?) I would find this quite a suprise if I had
to press C-u g for each article I edit in main groups. Ah,well.

jari

Re: [patch] 0.37 gnus-article-edit-article fix

[Lars Magne Ingebrigtsen]

<jari.aalto@poboxes.com> writes:

> Ehm, doesn't edit mean "edit the original article" after all that's
> written back to disk (no?) 

No.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen