qgnus0.17: no highlighting in message mode

qgnus0.17: no highlighting in message mode

[Mark Moll]

The patch for qgnus 0.17 contains the following chunk of code:
***************
*** 777,782 ****
--- 775,782 ----
         (0 'message-cited-text-face))))
    "Additional expressions to highlight in Message mode.")
  
+ (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
+ 
  (defvar message-face-alist
    '((bold . bold-region)
      (underline . underline-region)
***************
*** 1262,1269 ****
    (setq major-mode 'message-mode)
    (setq mode-name "Message")
    (setq buffer-offer-save t)
-   (make-local-variable 'font-lock-defaults)
-   (setq font-lock-defaults '(message-font-lock-keywords t))
    (make-local-variable 'facemenu-add-face-function)
    (make-local-variable 'facemenu-remove-face-function)
    (setq facemenu-add-face-function


This breaks the highlighting in message-mode for me. If I add the two
deleted lines again, everything works as usual. Has anybody else noticed
this? I'm using GNU Emacs 20.2.
-- 
Mark Moll                                              
e-mail: mmoll@cs.cmu.edu              |  Carnegie Mellon University
phone:  (412) 268 1120                |  Dept. of Computer Science
URL:    http://www.cs.cmu.edu/~mmoll  |  5000 Forbes Avenue
PGP:    finger e-mail address         |  Pittsburgh, PA  15213

Re: qgnus0.17: no highlighting in message mode

[Fredrik Glöckner]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Mark Moll <mmoll@cs.cmu.edu> writes:

| This breaks the highlighting in message-mode for me. If I add the two
| deleted lines again, everything works as usual. Has anybody else noticed
| this? I'm using GNU Emacs 20.2.

The same thing happens to me.  Being naïve, I was kinda waiting for a
new version of qgnus to fix it.

Fredrik

Re: qgnus0.17: no highlighting in message mode

[Lars Magne Ingebrigtsen]

Mark Moll <mmoll@cs.cmu.edu> writes:

> + (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
> + 

[...]

> This breaks the highlighting in message-mode for me. If I add the two
> deleted lines again, everything works as usual. Has anybody else noticed
> this? I'm using GNU Emacs 20.2.

Hm.  It was a patch I received from someone; it was supposed to be the
new right way of doing things.  I dunno.  Things seem to work for me
still... 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: qgnus0.17: no highlighting in message mode

[Fredrik Glöckner]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

| Hm.  It was a patch I received from someone; it was supposed to be the
| new right way of doing things.  I dunno.

I dunno too.  However, putting this thing in `.gnus' fixes the problem
for me.  It may not be an elegant solution, though.

(add-hook 'message-mode-hook
          '(lambda () 
             (make-local-variable 'font-lock-defaults)
             (setq font-lock-defaults '(message-font-lock-keywords t))))

Fredrik

Re: qgnus0.17: no highlighting in message mode

[Hrvoje Niksic]

Fredrik "Glöckner" <fredrik.glockner@bio.uio.no> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 
> | Hm.  It was a patch I received from someone; it was supposed to be the
> | new right way of doing things.  I dunno.
> 
> I dunno too.  However, putting this thing in `.gnus' fixes the problem
> for me.  It may not be an elegant solution, though.
> 
> (add-hook 'message-mode-hook
>           '(lambda () 
>              (make-local-variable 'font-lock-defaults)
>              (setq font-lock-defaults '(message-font-lock-keywords t))))

This patch should do it, I think:

--- message.el.orig	Thu Dec 18 21:36:29 1997
+++ message.el	Thu Dec 18 21:39:24 1997
@@ -774,6 +774,8 @@
        (0 'message-cited-text-face))))
   "Additional expressions to highlight in Message mode.")
 
+;; XEmacs does it like this.  For Emacs, we have to set the
+;; `font-lock-defaults' buffer-local variable.
 (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
 
 (defvar message-face-alist
@@ -1307,7 +1309,10 @@
 	(mail-abbrevs-setup)
       (funcall (intern "mail-aliases-setup"))))
   (message-set-auto-save-file-name)
-  (run-hooks 'text-mode-hook 'message-mode-hook))
+  (run-hooks 'text-mode-hook 'message-mode-hook)
+  (unless (string-match "XEmacs" emacs-version)
+    (set (make-local-variable 'font-lock-defaults)
+	 '(message-font-lock-keywords t))))
 
 \f
 


-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Idle RAM is the Devil's playground.

Re: qgnus0.17: no highlighting in message mode

[Dave Love]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

 Lars> Mark Moll <mmoll@cs.cmu.edu> writes:
 >> + (put 'message-mode 'font-lock-defaults '(message-font-lock-keywords t))
 >> + 

 Lars> [...]

 >> This breaks the highlighting in message-mode for me. If I add the
 >> two deleted lines again, everything works as usual. Has anybody
 >> else noticed this? I'm using GNU Emacs 20.2.

 Lars> Hm.  It was a patch I received from someone; it was supposed to
 Lars> be the new right way of doing things.  I dunno.  Things seem to
 Lars> work for me still...

It seems to be an (older?) XEmacs way of doing things.  It definitely
isn't Si's way for Emacs 19.34 or Emacs 20.

Re: qgnus0.17: no highlighting in message mode

[Lars Magne Ingebrigtsen]

Dave Love <d.love@dl.ac.uk> writes:

> It seems to be an (older?) XEmacs way of doing things.  It definitely
> isn't Si's way for Emacs 19.34 or Emacs 20.

Hm.  Ok.  I know noooothing about font-lock, so could someone look at
the problem and mail me a patch?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: qgnus0.17: no highlighting in message mode

[Dave Love]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

 Lars> Hm.  Ok.  I know noooothing about font-lock, so could someone
 Lars> look at the problem and mail me a patch?

It was gnus-bugged at the time.