Don't be overzealous when hiding cited text

Don't be overzealous when hiding cited text

[Elias Oltmanns]

Hi there,

unfortunately, Gnus can get a bit to eager for its own (or anyone's)
good when asked to hide cited text. Specifically, when there is a block
of cited text interspersed with one-line comments (no leading or
trailing blank lines), it will all be neatly folded away since Gnus
currently assumes a one-line interruption of cited text to be a blank
line.

Please find below a small patch to gnus-dissect-cited-text to fix this
issue. Also, since this bug may have rather unpleasant consequences, I'm
wondering whether this change could also be applied to the stable
branches that get pulled into point releases of emacs 22 / 23. It is not
obvious to me which branch in the gnus.git repository is propagated to
emacs 23, for example.

Regards,

Elias

---
commit cb823aae2f919b2f94b0eb13157d35acfd134a43
Author: Elias Oltmanns <eo@nebensachen.de>
Date:   Sun Mar 25 17:53:01 2012 +0200

    Don't be overzealous when hiding cited text
    
    A single line without citation prefix within a block of cited text
    should be considered part of that block *only* if it is a blank line.

diff --git a/lisp/gnus-cite.el b/lisp/gnus-cite.el
index c744344..6bcba71 100644
--- a/lisp/gnus-cite.el
+++ b/lisp/gnus-cite.el
@@ -509,6 +509,7 @@ Lines matching `gnus-cite-attribution-suffix' and perhaps
 	  (if (and (equal (cdadr m) "")
 		   (equal (cdar m) (cdaddr m))
 		   (goto-char (caadr m))
+		   (looking-at "[ \t]*$")
 		   (forward-line 1)
 		   (= (point) (caaddr m)))
 	      (setcdr m (cdddr m))

Re: Don't be overzealous when hiding cited text

[Lars Magne Ingebrigtsen]

Elias Oltmanns <eo@nebensachen.de> writes:

> unfortunately, Gnus can get a bit to eager for its own (or anyone's)
> good when asked to hide cited text. Specifically, when there is a block
> of cited text interspersed with one-line comments (no leading or
> trailing blank lines), it will all be neatly folded away since Gnus
> currently assumes a one-line interruption of cited text to be a blank
> line.

Thanks; applied to Ma Gnus.

> Please find below a small patch to gnus-dissect-cited-text to fix this
> issue. Also, since this bug may have rather unpleasant consequences, I'm
> wondering whether this change could also be applied to the stable
> branches that get pulled into point releases of emacs 22 / 23. It is not
> obvious to me which branch in the gnus.git repository is propagated to
> emacs 23, for example.

Emacs 22/23 are dead and will have no new releases.  Emacs 24.1 is in a
regression-only fix state, and this isn't a regression, so it won't show
up in Emacs until 24.3, which will happen in two years time, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/