Unable to use gnus on a nox build

Unable to use gnus on a nox build

[James Cloos]

I occasionally run gnus on a remote server.  That server runs debian and
the emacs-snapshot-nox package from http://emacs.orebokech.com.

Gnus there is as merged to emacs' trunk branch.

The current snapshot version is emacs-snapshot-nox_20101024-1_i386.deb.

Gnus on that version fails because the variables image-checkbox-checked &
image-checkbox-checked do not exist, emacs having been built w/o a gui.

I added a pair of setq-defaults to .emacs there, setting those two vars
to nil, to try to get gnus to start.

But that fails with:

Debugger entered--Lisp error: (void-variable image-load-path)
  image-search-load-path("gnus/toggle-subscription.xpm")
  gmm-image-load-path-for-library("gnus" "gnus/toggle-subscription.xpm" nil t)
  gnus-group-make-tool-bar()
  gnus-group-mode()
  gnus-group-setup-buffer()
  gnus-group-list-groups(nil)
  byte-code("^H\204^N^@ \204^N^@\306 \210\202Q^@\307\310!\210\311\n!^S\f\204^^^@^M\203!^@\312 \$
  gnus-1(nil nil nil)
  gnus(nil)
  call-interactively(gnus t nil)
  execute-extended-command(nil)
  call-interactively(execute-extended-command nil nil)

Gnus shouldn't screw around with toolbars on a nox emacs build.

Toolbar is not an option for gnus-visual, so that won't disable them.

And I do not see anything else in gnus' customize which might be
relevant.

Is there an option I'm missing?

This bug showed up in the previous emacs-snapshot; I wanted to check
whether it persisted to a second snapshot before reporting it.

(I might add that I do not want or use toolbars or menus in my gui
sessions either; there I use Xdefaults to disable them.)

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: Unable to use gnus on a nox build

[Reiner Steib]

On Tue, Oct 26 2010, James Cloos wrote:

> Debugger entered--Lisp error: (void-variable image-load-path)
>   image-search-load-path("gnus/toggle-subscription.xpm")
>   gmm-image-load-path-for-library("gnus" "gnus/toggle-subscription.xpm" nil t)
>   gnus-group-make-tool-bar()
>   gnus-group-mode()
>   gnus-group-setup-buffer()
>   gnus-group-list-groups(nil)
>   [...]
> Gnus shouldn't screw around with toolbars on a nox emacs build.

,----[ http://thread.gmane.org/gmane.emacs.gnus.general/69943/focus=69946 ]
| `gmm-image-load-path-for-library' in `gnus-group-make-tool-bar' is
| called only if `tool-bar-mode' is non-nil:
| 
|   (when (and (not (featurep 'xemacs))
| 	     (boundp 'tool-bar-mode)
| 	     tool-bar-mode
| 	     ;; The Gnus 5.10.6 code checked (default-value 'tool-bar-mode).
| 	     ;; Why?  --rsteib
| 	     (or (not gnus-group-tool-bar-map) force))
| 
| When I start "emacs -nw -Q", `tool-bar-mode' is nil.  Please show the
| output of `<f1> v tool-bar-mode RET'.
`----

The OP replied:

,----
| I did have a (setq tool-bar-mode -1) in my .emacs. Changing the -1 to
| nil fixed the problem. Sorry for the noise.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Unable to use gnus on a nox build

[James Cloos]

>>>>> "RS" == Reiner Steib <reinersteib+gmane@imap.cc> writes:

RS> On Tue, Oct 26 2010, James Cloos wrote:
>> Debugger entered--Lisp error: (void-variable image-load-path)

RS> ,----[ http://thread.gmane.org/gmane.emacs.gnus.general/69943/focus=69946 ]

RS> The OP replied:

RS> | I did have a (setq tool-bar-mode -1) in my .emacs. Changing the -1 to
RS> | nil fixed the problem. Sorry for the noise.

Adding a (setq tool-bar-mode nil) to .emacs worked.

But that should not be required on a -nox emacs build.  It is just silly
that everyone who wants to use gnus on a gui-less build should have to
add that sexp to their .emacs.

And you cannot use the customize interface to do it; customize-variable
does not see it because it is not marked to be customizable unless the
emacs build supports a GUI mode.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: Unable to use gnus on a nox build

[Reiner Steib]

On Thu, Oct 28 2010, James Cloos wrote:

> Adding a (setq tool-bar-mode nil) to .emacs worked.
>
> But that should not be required on a -nox emacs build.  It is just silly
> that everyone who wants to use gnus on a gui-less build should have to
> add that sexp to their .emacs.

The code checks if `tool-bar-mode' is bound and non-nil:

|   (when (and (not (featurep 'xemacs))
| 	       (boundp 'tool-bar-mode)
| 	       tool-bar-mode
| 	       ;; The Gnus 5.10.6 code checked (default-value 'tool-bar-mode).
| 	       ;; Why?  --rsteib
| 	       (or (not gnus-group-tool-bar-map) force))

If `tool-bar-mode' is non-nil in a no-X session, there is something
wrong, I'd say.  At least in Emacs 22.1, I have:

,----[ emacs -nw -Q -f ielm ]
| ELISP> tool-bar-mode
| nil
| ELISP> emacs-version
| "22.1.1"
`----

If this has changed in Emacs 24, I'd suggest to report it as a bug
(reproduce the failure and do M-x report-emacs-bug RET).

> And you cannot use the customize interface to do it; customize-variable
> does not see it because it is not marked to be customizable unless the
> emacs build supports a GUI mode.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Unable to use gnus on a nox build

[Julien Danjou]

On Thu, Oct 28 2010, James Cloos wrote:

> But that should not be required on a -nox emacs build.  It is just silly
> that everyone who wants to use gnus on a gui-less build should have to
> add that sexp to their .emacs.

I've pushed a fix.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

Re: Unable to use gnus on a nox build

[Reiner Steib]

On Fri, Oct 29 2010, Julien Danjou wrote:

> On Thu, Oct 28 2010, James Cloos wrote:
>
>> But that should not be required on a -nox emacs build.  It is just silly
>> that everyone who wants to use gnus on a gui-less build should have to
>> add that sexp to their .emacs.
>
> I've pushed a fix.

,----
| --- a/lisp/gnus-group.el
| +++ b/lisp/gnus-group.el
| @@ -1090,8 +1090,7 @@ When FORCE, rebuild the tool bar."
|    (when (and (not (featurep 'xemacs))
|  	     (boundp 'tool-bar-mode)
|  	     tool-bar-mode
| -	     ;; The Gnus 5.10.6 code checked (default-value 'tool-bar-mode).
| -	     ;; Why?  --rsteib
| +             (display-graphic-p)
|  	     (or (not gnus-group-tool-bar-map) force))
|      (let* ((load-path
|  	    (gmm-image-load-path-for-library "gnus"
`----

Hm, I think with this check, the failure will be deferred to
`gnus-summary-make-tool-bar' or `message-make-tool-bar' instead.

I still think it is a bug in Emacs 24, because tool-bar-mode should
not be non-nil in this case.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Unable to use gnus on a nox build

[James Cloos]

>>>>> "RS" == Reiner Steib <reinersteib+gmane@imap.cc> writes:

RS> Hm, I think with this check, the failure will be deferred to
RS> `gnus-summary-make-tool-bar' or `message-make-tool-bar' instead.

RS> I still think it is a bug in Emacs 24, because tool-bar-mode should
RS> not be non-nil in this case.

The bug report for that is <7299@debbugs.gnu.org>.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6