gnus-registry-split-fancy-with-parent and sender/subject

gnus-registry-split-fancy-with-parent and sender/subject

[Andrew Cohen]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

I rely heavily on splitting mail according to the registry (the
principal reason I do client side splitting) and just recently started
tracking sender and subject. I notice that splitting according to
references/in-reply-to obeys the ignore-groups variable, while splitting
by sender and subject do not. Is there a reason for this? If not I would
propose making them all behave the same way.


Attached is a suggested patch.

Regards,
Andy


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: registry-split-fancy change --]
[-- Type: text/x-diff, Size: 1201 bytes --]

diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el
index 6c2233f..79080f2 100644
--- a/lisp/gnus-registry.el
+++ b/lisp/gnus-registry.el
@@ -551,8 +551,9 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
 			    key
 			    gnus-registry-max-track-groups)))
 	       (dolist (group groups)
-		 (push group found-full)
-		 (setq found (append (list group) (delete group found)))))
+		 (when (and group (gnus-registry-follow-group-p group))
+		   (push group found-full)
+		   (setq found (append (list group) (delete group found))))))
 	     (push key matches)
 	     (gnus-message
 	      ;; raise level of messaging if gnus-registry-track-extra
@@ -580,8 +581,9 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
 			    key
 			    gnus-registry-max-track-groups)))
 	       (dolist (group groups)
-		 (push group found-full)
-		 (setq found (append (list group) (delete group found)))))
+		 (when (and group (gnus-registry-follow-group-p group))
+		   (push group found-full)
+		   (setq found (append (list group) (delete group found))))))
 	     (push key matches)
 	     (gnus-message
 	      ;; raise level of messaging if gnus-registry-track-extra

Re: gnus-registry-split-fancy-with-parent and sender/subject

[Lars Magne Ingebrigtsen]

Andrew Cohen <cohen@andy.bu.edu> writes:

> I rely heavily on splitting mail according to the registry (the
> principal reason I do client side splitting) and just recently started
> tracking sender and subject. I notice that splitting according to
> references/in-reply-to obeys the ignore-groups variable, while splitting
> by sender and subject do not. Is there a reason for this? If not I would
> propose making them all behave the same way.

I don't use the registry stuff, so I can't say whether this is
intentional or not.  But the patch looks reasonable, so I'll apply it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-registry-split-fancy-with-parent and sender/subject

[Ted Zlatanov]

On Mon, 18 Oct 2010 21:03:14 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Andrew Cohen <cohen@andy.bu.edu> writes:
>> I rely heavily on splitting mail according to the registry (the
>> principal reason I do client side splitting) and just recently started
>> tracking sender and subject. I notice that splitting according to
>> references/in-reply-to obeys the ignore-groups variable, while splitting
>> by sender and subject do not. Is there a reason for this? If not I would
>> propose making them all behave the same way.

LMI> I don't use the registry stuff, so I can't say whether this is
LMI> intentional or not.  But the patch looks reasonable, so I'll apply it.

Thanks.  I was going to do it today :)

Thanks, Andy.  There was no reason, I simply forgot to add it as you saw.

Ted