From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/15823 Path: main.gmane.org!not-for-mail From: Mike McEwan Newsgroups: gmane.emacs.gnus.general Subject: `gnus-group-read-group' doesn't use `select-article'? Date: 04 Aug 1998 20:53:42 +0100 Sender: owner-ding@hpc.uh.edu Message-ID: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 (generated by tm-edit 7.108) Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1035154792 24219 80.91.224.250 (20 Oct 2002 22:59:52 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 22:59:52 +0000 (UTC) Return-Path: Original-Received: from gwyn.tux.org (gwyn.tux.org [207.96.122.8]) by altair.xemacs.org (8.9.1/8.9.1) with ESMTP id NAA02833 for ; Tue, 4 Aug 1998 13:40:18 -0700 Original-Received: from gizmo.hpc.uh.edu (gizmo.hpc.uh.edu [129.7.102.31]) by gwyn.tux.org (8.8.8/8.8.8) with ESMTP id PAA30570 for ; Tue, 4 Aug 1998 15:56:30 -0400 Original-Received: from sina.hpc.uh.edu (sina.hpc.uh.edu [129.7.3.5]) by gizmo.hpc.uh.edu (8.7.6/8.7.3) with ESMTP id OAT01729; Tue, 4 Aug 1998 14:27:31 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 04 Aug 1998 14:55:57 -0500 (CDT) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [209.195.19.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id OAA11885 for ; Tue, 4 Aug 1998 14:55:44 -0500 (CDT) Original-Received: from post.mail.demon.net (post-12.mail.demon.net [194.217.242.41]) by sclp3.sclp.com (8.8.5/8.8.5) with SMTP id PAA08459 for ; Tue, 4 Aug 1998 15:55:35 -0400 (EDT) Original-Received: from (lotusland.demon.co.uk) [158.152.62.156] by post.mail.demon.net with smtp (Exim 1.82 #2) id 0z3nBB-0006vA-00; Tue, 4 Aug 1998 19:55:29 +0000 Original-Received: from mike by lotusland.demon.co.uk with local (Exim 2.01 #1) for ding@gnus.org id 0z3n9S-0000IF-00; Tue, 4 Aug 1998 20:53:42 +0100 Original-To: ding@gnus.org Original-Lines: 64 X-Mailer: Gnus v5.6.27/XEmacs 20.4 - "Emerald" Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:15823 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:15823 Well, I tinkered with the above `new' parameter to `gnus-group-read-group' and friends, but it just wasn't working. At least, not the way I expect it to. After the usual session with edebug it seemed that `select-article' wasn't being passed to from `gnus-summary-read-group' to `gnus-summary-read-group-1'. The following patch does it for me (Lars, I'm sure you can let me know if I'm missing something here). Having got `select-article' to be passed to `gnus-summary-read-group-1', I then noticed that where `old' articles were being selected due to `gnus-fetch-old-headers' not being `nil', they were all being marked `old' regardless. Setting `gnus-newsgroup-unselected' in the following, again, does it for me. -- Mike. --- ChangeLog.orig Tue Aug 4 04:26:20 1998 +++ ChangeLog Tue Aug 4 20:27:02 1998 @@ -1,3 +1,12 @@ +1998-08-04 Mike McEwan + + * gnus-sum.el (gnus-select-newsgroup): Set + `gnus-newsgroup-unselected' when selecting specific articles via + SELECT-ARTICLE - there may be more headers to fetch if + `gnus-fetch-old-headers' is non-nil. + (gnus-summary-read-group): pass SELECT-ARTICLE to + `gnus-summary-read-group-1' and reset to nil when going to next group. + Tue Aug 4 05:25:01 1998 Lars Magne Ingebrigtsen * gnus.el: Gnus v5.6.28 is released. --- gnus-sum.el.orig Mon Jul 27 02:25:51 1998 +++ gnus-sum.el Tue Aug 4 20:16:01 1998 @@ -2519,9 +2519,10 @@ (let ((gnus-auto-select-next nil)) (or (gnus-summary-read-group-1 group show-all no-article - kill-buffer no-display) - (setq show-all nil) - select-article)))) + kill-buffer no-display + select-article) + (setq show-all nil + select-article nil))))) (eq gnus-auto-select-next 'quietly)) (set-buffer gnus-group-buffer) ;; The entry function called above goes to the next @@ -3872,7 +3873,12 @@ (unless (gnus-ephemeral-group-p gnus-newsgroup-name) (gnus-group-update-group group)) - (setq articles (or select-articles (gnus-articles-to-read group read-all))) + (if (setq articles select-articles) + (setq gnus-newsgroup-unselected + (gnus-sorted-intersection + gnus-newsgroup-unreads + (gnus-sorted-complement gnus-newsgroup-unreads articles))) + (setq articles (gnus-articles-to-read group read-all))) (cond ((null articles)