error open imap while open-protocol-stream using network

error open imap while open-protocol-stream using network

[Binjo]

hi,

i'm using No Gnus under w32 + stunnel to get mail from gmail, since i use
stunnel, there's no need to concern about tls/ssl thing. i found gnus can't make
network stream while issue `open-protocol-stream' with service parameter as
_"9939"_ .

#v+
Unable to open server nnimap+gmail due to: Unknown service: 9939
#v-

after a little bit debug, it turns out the service(port?) should be 9939, rather
"9939". the following is the diff:

diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index c802a05..6d2cad4 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -348,7 +348,7 @@ textual parts.")
 	   (proto-stream-always-use-starttls t)
 	   connection-result login-result credentials)
       (when nnimap-server-port
-	(setq ports (append ports (list (format "%s" nnimap-server-port)))))
+	(setq ports (append ports (list nnimap-server-port))))
       (destructuring-bind (stream greeting capabilities)
 	  (open-protocol-stream
 	   "*nnimap*" (current-buffer) nnimap-address (car (last ports))

i simplly removed the format, it just works for me now. since i only use network,
i don't know if this will promote other issue, so please evaluate if this is
right.

HTH,

Binjo
-- 
Life is like a prison, can you break it?

Re: error open imap while open-protocol-stream using network

[Lars Magne Ingebrigtsen]

Binjo <binjo.cn@gmail.com> writes:

> i'm using No Gnus under w32 + stunnel to get mail from gmail, since i
> use stunnel, there's no need to concern about tls/ssl thing. i found
> gnus can't make network stream while issue `open-protocol-stream' with
> service parameter as _"9939"_ .

Ah, right.  Thanks for the patch; applied and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen