gnus-header-face-alist default value bug?

gnus-header-face-alist default value bug?

[Chunyu Wang]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]


I have set the gnus-header-newsgroups-face by M-x customize, But emacs
doesn't display correctly. So I changed the source as the following,
then it works. Is this a mistake?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 776 bytes --]

*** /home/spr/work/gnus/lisp/gnus-art.el        Thu Jul 10 13:01:09 2003
--- /usr/local/share/emacs/site-lisp/gnus/gnus-art.el   Mon Aug  4
20:55:05 2003
***************
*** 660,666 ****
  (defcustom gnus-header-face-alist
    '(("From" nil gnus-header-from-face)
      ("Subject" nil gnus-header-subject-face)
!     ("Newsgroups:.*," nil gnus-header-newsgroups-face)
      ("" gnus-header-name-face gnus-header-content-face))
    "*Controls highlighting of article header.

--- 660,666 ----
  (defcustom gnus-header-face-alist
    '(("From" nil gnus-header-from-face)
      ("Subject" nil gnus-header-subject-face)
!     ("Newsgroups" nil gnus-header-newsgroups-face)
      ("" gnus-header-name-face gnus-header-content-face))
    "*Controls highlighting of article header.


[-- Attachment #3: Type: text/plain, Size: 80 bytes --]


-- 
Harbin Institute of Technology, China.
Wang Chunyu <spr@db.cs.hit.edu.cn>.

Re: gnus-header-face-alist default value bug?

[Jesper Harder]

Chunyu Wang <spr@db.cs.hit.edu.cn> writes:

> I have set the gnus-header-newsgroups-face by M-x customize, But emacs
> doesn't display correctly. So I changed the source as the following,
> then it works. Is this a mistake?

Your patch looks correct.  I've commited it, thanks.

Re: gnus-header-face-alist default value bug?

[Katsumi Yamaoka]

>>>>> In <m3ispbli9v.fsf@defun.localdomain>
>>>>>	Jesper Harder <harder@myrealbox.com> wrote:

> Chunyu Wang <spr@db.cs.hit.edu.cn> writes:

>> I have set the gnus-header-newsgroups-face by M-x customize, But emacs
>> doesn't display correctly. So I changed the source as the following,
>> then it works. Is this a mistake?

> Your patch looks correct.  I've commited it, thanks.

I don't think so.  Doesn't the original regexp intend to
distinguish a cross-post and a single-post?
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-header-face-alist default value bug?

[Chunyu Wang]

>>>>> Katsumi Yamaoka writes:

>>>>> In <m3ispbli9v.fsf@defun.localdomain>
    >>>>>> 	Jesper Harder <harder@myrealbox.com> wrote:

    >>  Chunyu Wang <spr@db.cs.hit.edu.cn> writes:

    >>>  I have set the gnus-header-newsgroups-face by M-x customize, But emacs
    >>>  doesn't display correctly. So I changed the source as the following,
    >>>  then it works. Is this a mistake?

    >>  Your patch looks correct.  I've commited it, thanks.

    Katsumi> I don't think so.  Doesn't the original regexp intend to
    Katsumi> distinguish a cross-post and a single-post?

    The origional works with cross-post, but with single-post it
    doesn't. Now both ok.

    

-- 
Harbin Institute of Technology, China.
Chunyu Wang <spr@db.cs.hit.edu.cn>.

Re: gnus-header-face-alist default value bug?

[Simon Josefsson]

Chunyu Wang <spr@db.cs.hit.edu.cn> writes:

> I have set the gnus-header-newsgroups-face by M-x customize, But emacs
> doesn't display correctly. So I changed the source as the following,
> then it works. Is this a mistake?
>
> *** /home/spr/work/gnus/lisp/gnus-art.el        Thu Jul 10 13:01:09 2003
> --- /usr/local/share/emacs/site-lisp/gnus/gnus-art.el   Mon Aug  4
> 20:55:05 2003
> ***************
> *** 660,666 ****
>   (defcustom gnus-header-face-alist
>     '(("From" nil gnus-header-from-face)
>       ("Subject" nil gnus-header-subject-face)
> !     ("Newsgroups:.*," nil gnus-header-newsgroups-face)
>       ("" gnus-header-name-face gnus-header-content-face))
>     "*Controls highlighting of article header.
>
> --- 660,666 ----
>   (defcustom gnus-header-face-alist
>     '(("From" nil gnus-header-from-face)
>       ("Subject" nil gnus-header-subject-face)
> !     ("Newsgroups" nil gnus-header-newsgroups-face)
>       ("" gnus-header-name-face gnus-header-content-face))
>     "*Controls highlighting of article header.

I think the intention was that Newsgroups: headers only need to be
highlighted when they contain groups other than the current group,
i.e. for crossposts.  Various docstrings didn't reflect this, so your
patch is probably just as good as a patch that fixes the docstrings.

Re: gnus-header-face-alist default value bug?

[Jesper Harder]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>>> In <m3ispbli9v.fsf@defun.localdomain>
>>>>>>	Jesper Harder <harder@myrealbox.com> wrote:
>
>> Chunyu Wang <spr@db.cs.hit.edu.cn> writes:
>
>>> I have set the gnus-header-newsgroups-face by M-x customize, But emacs
>>> doesn't display correctly. So I changed the source as the following,
>>> then it works. Is this a mistake?
>
>> Your patch looks correct.  I've commited it, thanks.
>
> I don't think so.  Doesn't the original regexp intend to
> distinguish a cross-post and a single-post?

Ah, you're probably right.  Maybe we should just improve the docstring
for `gnus-header-newsgroups-face' instead?

    Face used for displaying newsgroups headers.

Which is currently a bit confusing if it's only intended to apply to
crossposts.

Re: gnus-header-face-alist default value bug?

[Katsumi Yamaoka]

>>>>> In <m2he4v1s4n.fsf@db.cs.hit.edu.cn>
>>>>>	Chunyu Wang <spr@db.cs.hit.edu.cn> wrote:

Katsumi> I don't think so.  Doesn't the original regexp intend to
Katsumi> distinguish a cross-post and a single-post?

> The origional works with cross-post, but with single-post it
> doesn't. Now both ok.

You can make a new face for single-post and customize the
gnus-header-face-alist variable.  I am just doing so. :)
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: gnus-header-face-alist default value bug?

[Chunyu Wang]

>>>>> Katsumi Yamaoka writes:

>>>>> In <m2he4v1s4n.fsf@db.cs.hit.edu.cn>
    >>>>>> 	Chunyu Wang <spr@db.cs.hit.edu.cn> wrote:

    Katsumi>  I don't think so.  Doesn't the original regexp intend to
    Katsumi>  distinguish a cross-post and a single-post?

    >>  The origional works with cross-post, but with single-post it
    >>  doesn't. Now both ok.

    Katsumi> You can make a new face for single-post and customize the
    Katsumi> gnus-header-face-alist variable.  I am just doing so. :)

    Yes, now I use my own gnus-header-face-alist. But before this, I
    don't know why I can't change the display by M-x customize. So I
    searched it in the sources, and changed it, and found that it works.

-- 
Harbin Institute of Technology, China.
Chunyu Wang <spr@db.cs.hit.edu.cn>.

Re: gnus-header-face-alist default value bug?

[Jesper Harder]

Jesper Harder <harder@myrealbox.com> writes:

> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> I don't think so.  Doesn't the original regexp intend to
>> distinguish a cross-post and a single-post?
>
> Ah, you're probably right.  Maybe we should just improve the docstring
> for `gnus-header-newsgroups-face' instead?

OK, I think this makes most sense.  So I added an explanation to the
docstring instead.

Re: gnus-header-face-alist default value bug?

[Katsumi Yamaoka]

>>>>> In <m3d6fifgrb.fsf@defun.localdomain>
>>>>>	Jesper Harder <harder@myrealbox.com> wrote:

> Jesper Harder <harder@myrealbox.com> writes:

>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>
>>> I don't think so.  Doesn't the original regexp intend to
>>> distinguish a cross-post and a single-post?
>>
>> Ah, you're probably right.  Maybe we should just improve the docstring
>> for `gnus-header-newsgroups-face' instead?

> OK, I think this makes most sense.  So I added an explanation to the
> docstring instead.

Thanks.  It may be better that the default value is a showy
sample. :)
-- 
Katsumi Yamaoka <yamaoka@jpl.org>