From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/42956
Path: main.gmane.org!not-for-mail
From: Jesper Harder <harder@ifa.au.dk>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: gnus-split-references tweak
Date: Thu, 07 Feb 2002 02:59:56 +0100
Sender: owner-ding@hpc.uh.edu
Message-ID: <m3adum2grn.fsf@defun.localdomain>
References: <m3n0ym4eyt.fsf@multivac.cwru.edu>
	<m3vgdal4gp.fsf@multivac.cwru.edu> <m37kpq8hd4.fsf@defun.localdomain>
	<m38za68fdy.fsf@multivac.cwru.edu>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035178126 14960 80.91.224.250 (21 Oct 2002 05:28:46 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 05:28:46 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: (qmail 17467 invoked from network); 7 Feb 2002 02:10:29 -0000
Original-Received: from malifon.math.uh.edu (mail@129.7.128.13)
  by mastaler.com with SMTP; 7 Feb 2002 02:10:29 -0000
Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 16Ye0X-0004KK-00; Wed, 06 Feb 2002 20:09:53 -0600
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 06 Feb 2002 20:09:28 -0600 (CST)
Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id UAA03478
	for <ding@hpc.uh.edu>; Wed, 6 Feb 2002 20:08:14 -0600 (CST)
Original-Received: (qmail 17439 invoked by alias); 7 Feb 2002 02:08:12 -0000
Original-Received: (qmail 17434 invoked from network); 7 Feb 2002 02:08:12 -0000
Original-Received: from fepz.post.tele.dk (195.41.46.133)
  by gnus.org with SMTP; 7 Feb 2002 02:08:12 -0000
Original-Received: from defun.localdomain ([195.249.130.13]) by fepZ.post.tele.dk
          (InterMail vM.4.01.03.23 201-229-121-123-20010418) with ESMTP
          id <20020207020809.DEIE395.fepZ.post.tele.dk@defun.localdomain>
          for <ding@gnus.org>; Thu, 7 Feb 2002 03:08:09 +0100
Original-To: ding@gnus.org
In-Reply-To: <m38za68fdy.fsf@multivac.cwru.edu> (prj@po.cwru.edu's message
 of "Wed, 6 Feb 2002 21:35:07 +0000 (UTC)")
Original-Lines: 32
User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.1 (i686-pc-linux-gnu)
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:42956
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:42956

prj@po.cwru.edu (Paul Jarc) writes:

> Jesper Harder <harder@ifa.au.dk> wrote:
>> prj@po.cwru.edu (Paul Jarc) writes:
>>> Hm.  It seems this actually isn't sufficient for recognizing them
>>> anyway.  I'm not sure what else would need to be changed, though.
>>
>> Maybe you also have to change the regexp in `gnus-parent-id':
>>
>>       (when (string-match "<[^> \t]+>\\'" references)
>
> Oops.  Yep, that works.  I'll commit it tomorrow if no one objects.
> -      (when (string-match "<[^> \t]+>\\'" references)
> -       (match-string 0 references)))))
> +      (when (string-match "\(<[^<]+[^< \t]\)[ \t]*\\'" references)
> +       (match-string 1 references)))))

You missed a couple of backslashes in the regexp, it should be

  "\\(<[^<]+[^< \t]\\)[ \t]*\\'"

But this regexp is rather expensive compared to the old one
(`gnus-parent-id' is called several times on each article).  Entering a
10k group was 15% slower for me.

I think this one:

      (when (string-match "\\(<[^>]+>\\)[ \t]*\\'" references)
	(match-string 1 references)))))

is more efficient -- the performance penalty was only about 2%.