Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Tassilo Horn <tassilo@member.fsf.org>
Cc: ding@gnus.org
Subject: Re: Problem with gnus-parameters
Date: Sat, 07 Jan 2012 01:36:34 +0100	[thread overview]
Message-ID: <m3boqg4act.fsf@stories.gnus.org> (raw)
In-Reply-To: <871urcqu6u.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Sat, 07 Jan 2012 00:37:13 +0100")

Tassilo Horn <tassilo@member.fsf.org> writes:

>  '(("gmane"      (foo "lala") (bar "zot") (gcc-self . t))
>    ("emacs"      (foo "emacs")                          ))

[...]

> To me, that inconsistency between group local variables and group
> parameters is far from obvious.  I'd prefer, if in gmane.emacs gcc-self
> was active, too, i.e., I'd expect these effects:
>
>      gmane.foo:   foo=lala,    bar=zot,    gcc-self
>      gmane.emacs: foo=emacs,   bar=zot,    gcc-self

Yes, this is clearly a bug, I think:

(gnus-group-find-parameter "nntp+news.gmane.org:gmane.emacs.test" 'gcc-self)
=> nil

(gnus-group-find-parameter "nntp+news.gmane.org:gmane.emacs.test")
=> ((foo "emacs") (gcc-self . t) (bar "zot") (foo "lala"))

And it's because of this:

(defun gnus-group-find-parameter (group &optional symbol allow-list)

[...]

    (if symbol
	(gnus-group-fast-parameter group symbol allow-list)
      (nconc
       (copy-sequence
	(funcall gnus-group-get-parameter-function group))
       (gnus-parameters-get-parameter group)))))

So the "fast" version applies the precedence in a different way than the
non-fast version does.

I've now fixed the -fast- function to do what it's supposed to.  Give it
a whirl and see whether I've ironed out all the kinks...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/



  reply	other threads:[~2012-01-07  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 19:54 Tassilo Horn
2011-11-29  4:47 ` Katsumi Yamaoka
2011-11-29  8:37   ` Tassilo Horn
2012-01-03 21:15     ` Lars Magne Ingebrigtsen
2012-01-04  7:33       ` Tassilo Horn
2012-01-04 20:03         ` Lars Magne Ingebrigtsen
2012-01-05 10:00           ` Tassilo Horn
2012-01-06 20:41             ` Lars Magne Ingebrigtsen
2012-01-06 20:43               ` Lars Magne Ingebrigtsen
2012-01-06 22:27                 ` Tassilo Horn
2012-01-06 22:44                   ` Lars Magne Ingebrigtsen
2012-01-06 22:52                     ` Tassilo Horn
2012-01-06 23:13                       ` Lars Magne Ingebrigtsen
2012-01-06 23:37                         ` Tassilo Horn
2012-01-07  0:36                           ` Lars Magne Ingebrigtsen [this message]
2012-01-07  8:08                             ` Tassilo Horn
2012-01-06 22:20               ` Tassilo Horn
2012-01-06 22:31                 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3boqg4act.fsf@stories.gnus.org \
    --to=larsi@gnus.org \
    --cc=ding@gnus.org \
    --cc=tassilo@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).