Gnus development mailing list
 help / color / mirror / Atom feed
* `B r' doesn't work
       [not found] <E1OwdeG-0002R5-00@quimby.gnus.org>
@ 2010-09-21  4:56 ` Katsumi Yamaoka
  2010-09-21 16:00   ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Katsumi Yamaoka @ 2010-09-21  4:56 UTC (permalink / raw)
  To: ding

Lars Magne Ingebrigtsen wrote:
> commit df6ac45b952171e7e709c1b0bf23cc7346429f81
> Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
> Date:   Fri Sep 17 18:18:39 2010 +0200
[...]
>     * gnus-sum.el (gnus-summary-move-article): Pass the move-to group name
>     if the move is internal, so that nnimap can do fast internal moves.
[...]
> diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
> index df20456..c8c4a1c 100644
> --- a/lisp/gnus-sum.el
> +++ b/lisp/gnus-sum.el
> @@ -9690,7 +9690,8 @@ ACTION can be either `move' (the default), `crosspost' or `copy'."
>                   to-newsgroup (list 'quote select-method)
>                   (not articles) t)     ; Accept form
>             (not articles)              ; Only save nov last time
> -           move-is-internal)))         ; is this move internal?
> +           (and move-is-internal
> +                (gnus-group-real-name to-newsgroup))))) ; is this move internal?

It seems to have to be:

 (and move-is-internal
      to-newsgroup
      (gnus-group-real-name to-newsgroup))))) ; is this move internal?

Because `to-newsgroup' is nil if this function runs by way of
`gnus-summary-respool-article' (i.e. `B r').  I got this error
when respooling articles in nnml groups:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-match("^[^:]+:" nil)
  gnus-summary-move-article(nil nil (nnml ""))
  gnus-summary-respool-article(nil (nnml ""))
  call-interactively(gnus-summary-respool-article nil nil)



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: `B r' doesn't work
  2010-09-21  4:56 ` `B r' doesn't work Katsumi Yamaoka
@ 2010-09-21 16:00   ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-09-21 16:00 UTC (permalink / raw)
  To: ding

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> It seems to have to be:
>
>  (and move-is-internal
>       to-newsgroup
>       (gnus-group-real-name to-newsgroup))))) ; is this move internal?
>
> Because `to-newsgroup' is nil if this function runs by way of
> `gnus-summary-respool-article' (i.e. `B r').  I got this error
> when respooling articles in nnml groups:

Ok; fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-21 16:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <E1OwdeG-0002R5-00@quimby.gnus.org>
2010-09-21  4:56 ` `B r' doesn't work Katsumi Yamaoka
2010-09-21 16:00   ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).