Re: defface/defcustom question

[Jesper Harder <harder@myrealbox.com>]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

Simon Josefsson <jas@extundo.com> writes:

> kai.grossjohann@gmx.net (Kai Großjohann) writes:
>
>> Simon Josefsson <jas@extundo.com> writes:
>>
>>> It also makes it possible to express "use the same face for this, that
>>> and this" and then later be able to change the face only once to
>>> change it in all places.
>>
>> But that's possible with regular faces already?  Just use the same
>> symbol (face name) in all those places?
>
> You mean changing gnus source?  I meant for users.

I think it's harder to understand for users.  It's confusing to have
two customization options with the same name (and very similar
purpose).

>>> And it simplifies font-lock stuff, compare
>>> gnus-server-font-lock-keywords.
>>
>> I looked at it.  It looks simple.  But I can't see how variables made
>> it simpler.
>
> font-lock-keywords uses face names, not faces.  Compare
> info://Elisp/Faces%20for%20Font%20Lock

I don't see your point.  This just means that you need to quote the
name of the face -- I thinks that's a lot simpler than an extra layer
of indirection.  E.g.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-srvr.el.diff --]
[-- Type: text/x-patch, Size: 1598 bytes --]

--- gnus/lisp/gnus-srvr.el	Tue Jun 24 07:22:43 2003
+++ cvsgnus/lisp/gnus-srvr.el	Sat Aug  9 15:50:22 2003
@@ -202,38 +202,13 @@
   "Face used for displaying OFFLINE servers"
   :group 'gnus-server-visual)
 
-(defcustom gnus-server-agent-face 'gnus-server-agent-face
-  "Face name to use on AGENTIZED servers."
-  :group 'gnus-server-visual
-  :type 'face)
-
-(defcustom gnus-server-opened-face 'gnus-server-opened-face
-  "Face name to use on OPENED servers."
-  :group 'gnus-server-visual
-  :type 'face)
-
-(defcustom gnus-server-closed-face 'gnus-server-closed-face
-  "Face name to use on CLOSED servers."
-  :group 'gnus-server-visual
-  :type 'face)
-
-(defcustom gnus-server-denied-face 'gnus-server-denied-face
-  "Face name to use on DENIED servers."
-  :group 'gnus-server-visual
-  :type 'face)
-
-(defcustom gnus-server-offline-face 'gnus-server-offline-face
-  "Face name to use on OFFLINE servers."
-  :group 'gnus-server-visual
-  :type 'face)
-
 (defvar gnus-server-font-lock-keywords
   (list
-   '("(\\(agent\\))" 1 gnus-server-agent-face)
-   '("(\\(opened\\))" 1 gnus-server-opened-face)
-   '("(\\(closed\\))" 1 gnus-server-closed-face)
-   '("(\\(offline\\))" 1 gnus-server-offline-face)
-   '("(\\(denied\\))" 1 gnus-server-denied-face)))
+   '("(\\(agent\\))" 1 'gnus-server-agent-face)
+   '("(\\(opened\\))" 1 'gnus-server-opened-face)
+   '("(\\(closed\\))" 1 'gnus-server-closed-face)
+   '("(\\(offline\\))" 1 'gnus-server-offline-face)
+   '("(\\(denied\\))" 1 'gnus-server-denied-face)))
 
 (defun gnus-server-mode ()
   "Major mode for listing and editing servers.