pgnus 0.94 Signaling: (void-variable buffer-file-coding-system)

pgnus 0.94 Signaling: (void-variable buffer-file-coding-system)

[Roman Milner]

On XEmacs 21.3 sans mule - when I try to save a text/html mime part:

Signaling: (void-variable buffer-file-coding-system)
  mm-save-part-to-file((#<buffer " *mm*<2>"> ("text/html" (name
. "footer.html")) nil (lambda nil (let ... ... ...)) ("inline"
(filename . "footer.html")) "footer.html" nil nil) "~/footer.html")
  mm-save-part((#<buffer " *mm*<2>"> ("text/html" (name
. "footer.html")) nil (lambda nil (let ... ... ...)) ("inline"
(filename . "footer.html")) "footer.html" nil nil))
  #<compiled-function nil "...(13)" [gnus-article-check-buffer
get-text-property gnus-data data mm-save-part] 3
("/usr/src/elisp/sgnus/gnus-art.elc" . 74855) nil>()
  call-interactively(gnus-mime-save-part)
  gnus-mime-button-menu(#<buttondown-event button3>)
  call-interactively(gnus-mime-button-menu)

Re: pgnus 0.94 Signaling: (void-variable buffer-file-coding-system)

[Shenghuo ZHU]

>>>>> "Roman" == Roman Milner <roman@speeder.com> writes:

Roman> On XEmacs 21.3 sans mule - when I try to save a text/html mime part:

Roman> Signaling: (void-variable buffer-file-coding-system)
Roman>   mm-save-part-to-file((#<buffer " *mm*<2>"> ("text/html" (name
Roman> . "footer.html")) nil (lambda nil (let ... ... ...)) ("inline"
Roman> (filename . "footer.html")) "footer.html" nil nil) "~/footer.html")
Roman>   mm-save-part((#<buffer " *mm*<2>"> ("text/html" (name
Roman> . "footer.html")) nil (lambda nil (let ... ... ...)) ("inline"
Roman> (filename . "footer.html")) "footer.html" nil nil))
Roman>   #<compiled-function nil "...(13)" [gnus-article-check-buffer
Roman> get-text-property gnus-data data mm-save-part] 3
Roman> ("/usr/src/elisp/sgnus/gnus-art.elc" . 74855) nil>()
Roman>   call-interactively(gnus-mime-save-part)
Roman>   gnus-mime-button-menu(#<buttondown-event button3>)
Roman>   call-interactively(gnus-mime-button-menu)

,--------  Line 569 of mm-decode.el
|     (let ((coding-system-for-write
| 	   (if (equal "text" (mm-handle-media-supertype handle))
| 	       buffer-file-coding-system
| 	     'binary))
`--------

I guess using nil instead of buffer-file-coding-system should fix the
bug, because in XEmacs w/ mule, buffer-file-coding-system is used for
writing if coding-system-for-write is nil, and in XEmacs w/o mule, it
will not cause unbounded error.


-- 
Shenghuo ZHU

Re: pgnus 0.94 Signaling: (void-variable buffer-file-coding-system)

[Lars Magne Ingebrigtsen]

Shenghuo ZHU <zsh@cs.rochester.edu> writes:

> |     (let ((coding-system-for-write
> | 	   (if (equal "text" (mm-handle-media-supertype handle))
> | 	       buffer-file-coding-system
> | 	     'binary))
> `--------
> 
> I guess using nil instead of buffer-file-coding-system should fix the
> bug, because in XEmacs w/ mule, buffer-file-coding-system is used for
> writing if coding-system-for-write is nil, and in XEmacs w/o mule, it
> will not cause unbounded error.

Perhaps coding-system-for-write should be 'binary in all cases, since
we are in `mm-with-unibyte-buffer' anyway...  I've made this fix to
0.96. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen