From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/19291 Path: main.gmane.org!not-for-mail From: Mike McEwan Newsgroups: gmane.emacs.gnus.general Subject: Picons broken in 0.55 (was Re: pgnus 0.55 Summary Mode line broken) Date: 29 Nov 1998 14:54:30 +0000 Sender: owner-ding@hpc.uh.edu Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 X-Trace: main.gmane.org 1035157667 10849 80.91.224.250 (20 Oct 2002 23:47:47 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 23:47:47 +0000 (UTC) Return-Path: Original-Received: from karazm.math.uh.edu (karazm.math.uh.edu [129.7.128.1]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id KAA18312 for ; Sun, 29 Nov 1998 10:12:27 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by karazm.math.uh.edu (8.9.1/8.9.1) with ESMTP id JAB13892; Sun, 29 Nov 1998 09:12:05 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sun, 29 Nov 1998 09:12:01 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id JAA19993 for ; Sun, 29 Nov 1998 09:11:52 -0600 (CST) Original-Received: from post.mail.demon.net (post-11.mail.demon.net [194.217.242.40]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id KAA18302 for ; Sun, 29 Nov 1998 10:11:45 -0500 (EST) Original-Received: from [158.152.62.156] (helo=lotusland.demon.co.uk) by post.mail.demon.net with esmtp (Exim 2.054 #1) id 0zk8Vh-0006U5-00 for ding@gnus.org; Sun, 29 Nov 1998 15:11:41 +0000 Original-Received: from mike by lotusland.demon.co.uk with local (Exim 2.05 #1) id 0zk8Vf-0000J0-00 for ding@gnus.org; Sun, 29 Nov 1998 15:11:39 +0000 Original-To: ding@gnus.org In-Reply-To: Lars Magne Ingebrigtsen's message of "28 Nov 1998 01:19:24 +0100" User-Agent: Gnus/5.070055 (Pterodactyl Gnus v0.55) XEmacs/21.0 (Pyrenean-pre8) Original-Lines: 80 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:19291 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:19291 Lars Magne Ingebrigtsen writes: > Graham Murray writes: > > > It seems as though the Article buffer mode line is being updated > > into the Summary buffer line rather than its own. > > Yup. Fix in Pterodactyl Gnus v0.56. Pgnus-0.55 breaks picons in the article buffer for the same reason. In the meantime I'm applying the following patch. It removes the `save-selected-window' stuff from the top of `gnus-display-mime'. Lars, presumably this was put there for a reason, although I've not discovered any more breakage (yet) after its removal? --- gnus-art.el 1998/11/29 01:29:53 1.1.1.12 +++ gnus-art.el 1998/11/29 14:13:22 @@ -2497,34 +2497,30 @@ (defun gnus-display-mime (&optional ihandles) "Insert MIME buttons in the buffer." - (save-selected-window - (let ((window (get-buffer-window gnus-article-buffer))) - (when window - (select-window window))) - (let* ((handles (or ihandles (mm-dissect-buffer) (mm-uu-dissect))) - handle name type b e display) + (let* ((handles (or ihandles (mm-dissect-buffer) (mm-uu-dissect))) + handle name type b e display) + (unless ihandles + ;; Top-level call; we clean up. + (mm-destroy-parts gnus-article-mime-handles) + (setq gnus-article-mime-handles handles + gnus-article-mime-handle-alist nil) + ;; We allow users to glean info from the handles. + (when gnus-article-mime-part-function + (gnus-mime-part-function handles))) + (when (and handles + (or (not (stringp (car handles))) + (cdr handles))) (unless ihandles - ;; Top-level call; we clean up. - (mm-destroy-parts gnus-article-mime-handles) - (setq gnus-article-mime-handles handles - gnus-article-mime-handle-alist nil) - ;; We allow users to glean info from the handles. - (when gnus-article-mime-part-function - (gnus-mime-part-function handles))) - (when (and handles - (or (not (stringp (car handles))) - (cdr handles))) - (unless ihandles - ;; Clean up for mime parts. - (article-goto-body) - (delete-region (point) (point-max))) - (if (stringp (car handles)) - (if (equal (car handles) "multipart/alternative") - (let ((id (1+ (length gnus-article-mime-handle-alist)))) - (push (cons id handles) gnus-article-mime-handle-alist) - (gnus-mime-display-alternative (cdr handles) nil nil id)) - (gnus-mime-display-mixed (cdr handles))) - (gnus-mime-display-single handles)))))) + ;; Clean up for mime parts. + (article-goto-body) + (delete-region (point) (point-max))) + (if (stringp (car handles)) + (if (equal (car handles) "multipart/alternative") + (let ((id (1+ (length gnus-article-mime-handle-alist)))) + (push (cons id handles) gnus-article-mime-handle-alist) + (gnus-mime-display-alternative (cdr handles) nil nil id)) + (gnus-mime-display-mixed (cdr handles))) + (gnus-mime-display-single handles))))) (defun gnus-mime-part-function (handles) (if (stringp (car handles)) -- Mike.