Bug in `gnus-summary-increase-score'?

Bug in `gnus-summary-increase-score'?

[Mike McEwan]

  Having just installed 5.6.30, I cannot now conduct a `I T' to
increase the score of a thread. Or rather, I can, but I then cannot
re-select the group in question - gnus just gets stuck in a loop with
`Scoring...' in the mini-buffer. An `ADAPT' score file is also
created???

  I've tracked the problem down to the following in 5.6.30:

--- gnus/lisp/gnus-score.el.orig	Sat Aug  8 18:43:41 1998
+++ gnus/lisp/gnus-score.el	Sun Aug  9 18:11:32 1998
@@ -550,7 +550,7 @@
 	      (gnus-score-insert-help "Match on header" char-to-header 1)))
 
 	  (gnus-score-kill-help-buffer)
-	  (unless (setq entry (assq (downcase hchar) char-to-header))
+	  (unless (setq entry (assq hchar char-to-header))
 	    (if mimic (error "%c %c" prefix hchar)
 	      (error "Illegal header type")))
 
  Reverting this patch, having removed the `ADAPT' file and score file 
entry previously created, resumes normal behaviour. I just don't know
why yet - any ideas?

-- 
Mike.

Re: Bug in `gnus-summary-increase-score'?

[Mike McEwan]

Mike McEwan <mike@lotusland.demon.co.uk> writes:

>   Having just installed 5.6.30, I cannot now conduct a `I T' to
> increase the score of a thread. Or rather, I can, but I then cannot
> re-select the group in question - gnus just gets stuck in a loop with
> `Scoring...' in the mini-buffer. An `ADAPT' score file is also
> created???
  
  Whoops! Looks like I didn't really understand scoring *threads*
since I've never had the option prior to 5.6.30 :-/. I was hitting
`I T' followed by `RET' too quickly to notice that the `match' entry
of the message-id was being entered into my scorefile as "", when
attempting to score on the first article in a thread. I'm not sure
this scoring on the references of a *sub-thread* is what I want, I'll
have to dwell on it a little longer.

  I see "implement gnus-score-thread" is still in the `Newest
Features' section of the manual. Is this to be something which will
operate on an entire thread from top to bottom?

-- 
Mike.

Re: Bug in `gnus-summary-increase-score'?

[Lars Magne Ingebrigtsen]

Mike McEwan <mike@lotusland.demon.co.uk> writes:

>   I see "implement gnus-score-thread" is still in the `Newest
> Features' section of the manual. Is this to be something which will
> operate on an entire thread from top to bottom?

Uhm...  No, I think I've just forgotten to take that out of the todo
list after implementing it.  Of course, I could be wrong.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen