[PATCH] Allow topic catch-up with some groups available and some disconnected

[PATCH] Allow topic catch-up with some groups available and some disconnected

[Nelson Ferreira]

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]



Hi all,

I came across an issue where Gnus would abort topic catchup when some
of the groups where from an unavailable server:

Debugger entered--Lisp error: (wrong-type-argument number-char-or-marker-p nil)
  gnus-sequence-of-unread-articles("nntp+news.optonline.net:comp.software.patterns")
  gnus-group-catchup("nntp+news.optonline.net:comp.software.patterns" nil)
  gnus-group-catchup-current()
  #<compiled-function (topic) "...(32)" [gnus-group-marked buffer-read-only gnus-level-killed topic groups call-interactively gnus-group-catchup-current mapcar #<compiled-function ... "...(5)" ... 2> gnus-topic-find-groups t nil gnus-topic-update-topics-containing-group] 8 ("/usr/lib/sxemacs/site-packages/lisp/gnus/gnus-topic.elc" . 25793) (list (gnus-group-topic-name))>("Engineering")
  call-interactively(gnus-topic-catchup-articles)

The following patch is a naive approach at solving it.
I realize I am just silencing the error, which might be bad, but it
works for me.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus.topic.catchup.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

Index: gnus-group.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-group.el,v
retrieving revision 7.55
diff -u -u -b -r7.55 gnus-group.el
--- gnus-group.el	26 Oct 2005 14:53:25 -0000	7.55
+++ gnus-group.el	31 Oct 2005 23:36:13 -0000
@@ -1049,7 +1056,7 @@
     (gnus-group-make-tool-bar))
   (gnus-simplify-mode-line)
   (setq major-mode 'gnus-group-mode)
-  (setq mode-name "Group")
+  (setq mode-name gnus-group-mode-line-string)
   (gnus-group-set-mode-line)
   (setq mode-line-process nil)
   (use-local-map gnus-group-mode-map)
@@ -3176,9 +3183,11 @@
 	     (gnus-group-real-name group) (nth 1 method) all)))
 	(if (>= (gnus-group-level group) gnus-level-zombie)
 	    (gnus-message 2 "Dead groups can't be caught up")
-	  (if (prog1
+	  (if (condition-case nil
+                  (prog1
 		  (gnus-group-goto-group group)
 		(gnus-group-catchup group all))
+                  (t  nil))
 	      (gnus-group-update-group-line)
 	    (setq ret (1+ ret)))))
       (gnus-group-next-unread-group 1)

[-- Attachment #3: Type: text/plain, Size: 22 bytes --]



-- 
Nelson Ferreira

Re: [PATCH] Allow topic catch-up with some groups available and some disconnected

[Lars Magne Ingebrigtsen]

Nelson Ferreira <nelson.ferreira@ieee.org> writes:

> I came across an issue where Gnus would abort topic catchup when some
> of the groups where from an unavailable server:
>
> Debugger entered--Lisp error: (wrong-type-argument number-char-or-marker-p nil)
>   gnus-sequence-of-unread-articles("nntp+news.optonline.net:comp.software.patterns")

I think the best would be to fix this function not to break when
called this way.

Could you (load "gnus-sum.el") to get a better backtrace and repeat
the bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen