Gnus development mailing list
 help / color / mirror / Atom feed
From: Jesper Harder <harder@ifa.au.dk>
Subject: Re: Exact article count for nnml groups
Date: Fri, 12 Mar 2004 23:23:31 +0100	[thread overview]
Message-ID: <m3d67h4sd8.fsf@defun.localdomain> (raw)
In-Reply-To: <uish9sxu9.fsf@isisSEND.vanderbiltME.eduSPAM> (David Hanak's message of "Fri, 12 Mar 2004 12:51:26 -0600")

David Hanak <dhanak@isis.vanderbilt.edu> writes:

A few comments on the code:

> + (defcustom gnus-count-articles-in-groups nil
> + "*Regexp to match groups whose article count should be determined
> + accurately upon entering the group.  Non-matching groups are conventionally
> + looked up in the active info.

If possible try to follow the style guide for docstrings in
<info://elisp/Documentation+Tips>.

> +   (condition-case ()

It's harder to debug code inside `condition-case'.  It's better if you
can restrict to just the form(s) that you know might signal an error
(and you know that the error can safely be ignored, of course).

> + 	(delete-region (point) (line-end-position))

You need to use `point-at-bol' to be compatible with XEmacs.

> + 	(save-excursion
> + 	  (set-buffer nntp-server-buffer)

A slightly more concise way of doing this is

       (with-current-buffer nntp-server-buffer
         ...)



  reply	other threads:[~2004-03-12 22:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-12 18:51 David Hanak
2004-03-12 22:23 ` Jesper Harder [this message]
2004-03-13 16:07   ` Michael Schierl
2004-03-15 17:03   ` David Hanak
2004-03-17 16:04     ` Kai Grossjohann
2004-03-12 23:56 ` Kevin Greiner
2004-05-16 14:38   ` Lars Magne Ingebrigtsen
2004-03-13 12:15 ` Kai Grossjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d67h4sd8.fsf@defun.localdomain \
    --to=harder@ifa.au.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).