From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/56715 Path: main.gmane.org!not-for-mail From: Jesper Harder Newsgroups: gmane.emacs.gnus.general Subject: Re: Exact article count for nnml groups Date: Fri, 12 Mar 2004 23:23:31 +0100 Sender: ding-owner@lists.math.uh.edu Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079130333 10573 80.91.224.253 (12 Mar 2004 22:25:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 12 Mar 2004 22:25:33 +0000 (UTC) Original-X-From: ding-owner+M5254@lists.math.uh.edu Fri Mar 12 23:25:25 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B1v5o-0002CV-00 for ; Fri, 12 Mar 2004 23:25:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1B1v5F-0008GU-00; Fri, 12 Mar 2004 16:24:49 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1B1v57-0008GM-00 for ding@lists.math.uh.edu; Fri, 12 Mar 2004 16:24:41 -0600 Original-Received: from pfepb.post.tele.dk (pfepb.post.tele.dk [195.41.46.236]) by justine.libertine.org (Postfix) with ESMTP id 348253A003D for ; Fri, 12 Mar 2004 16:24:40 -0600 (CST) Original-Received: from [195.215.224.224] (0xc3d7e0e0.esnxr4.ras.tele.dk [195.215.224.224]) by pfepb.post.tele.dk (Postfix) with ESMTP id 2DB785EE02E for ; Fri, 12 Mar 2004 23:24:37 +0100 (CET) Original-To: ding@gnus.org Mail-Followup-To: ding@gnus.org In-Reply-To: (David Hanak's message of "Fri, 12 Mar 2004 12:51:26 -0600") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:56715 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:56715 David Hanak writes: A few comments on the code: > + (defcustom gnus-count-articles-in-groups nil > + "*Regexp to match groups whose article count should be determined > + accurately upon entering the group. Non-matching groups are conventionally > + looked up in the active info. If possible try to follow the style guide for docstrings in . > + (condition-case () It's harder to debug code inside `condition-case'. It's better if you can restrict to just the form(s) that you know might signal an error (and you know that the error can safely be ignored, of course). > + (delete-region (point) (line-end-position)) You need to use `point-at-bol' to be compatible with XEmacs. > + (save-excursion > + (set-buffer nntp-server-buffer) A slightly more concise way of doing this is (with-current-buffer nntp-server-buffer ...)