Re: spam-stat.el and mime

[Jesper Harder <harder@ifa.au.dk>]

Andrew Cohen <cohen@andy.bu.edu> writes:

> I've modified it to decode mime (if you don't like this it can be
> controlled by customizing the spam-treat-mime-function to nil).

An often requested feature!  Below a few pedantic comments on the
code:

> + 	  ;; We allow users to glean info from the handles.
> + 	  (when gnus-article-mime-part-function
> + 	    (gnus-mime-part-function handles)))

If someone is using this feature, they probably don't want to run
`gnus-article-mime-part-function' when processing spam.

> +       (if (gnus-buffer-live-p (current-buffer))

(current-buffer) always returns a live buffer, so you don't need this
line.

> + 	  (with-current-buffer (current-buffer)

This line should also be redundant.

> +       (if (and type (let ((case-fold-search t))
> + 		      (string-match "quoted-printable" type)))
> + 	  (progn
> + 	    (article-goto-body)
> + 	    (quoted-printable-decode-region
> + 	     (point) (point-max) (mm-charset-to-coding-system charset)))
> + 	(progn
> + 	  (when (and type (let ((case-fold-search t))

You don't need a progn around the ELSE part of an `if' in Emacs Lisp
(in contrast with Common Lisp).