Patch for gnus-nocem

Patch for gnus-nocem

[Edwin Steiner]

Hello Gnus Developers!

Today I activated NoCeM scanning and it did not work. I tracked the
problem down to the following: Most of my news groups are on a
secondary server, so they have names like nntp+<server>:<groupname>. The
code in gnus-nocem.el checks against gnus-active-hashtb which contains
these names, not the real group names.

The patch below solves this problem. The lookup is now done in
gnus-nocem-real-group-hashtb which contains the real group names. (And
I think gnus-active-hashtb should not be modified by nocem anyway,
right?)

This patch makes the check in the following when clause partially
redundant. You could substitute

	  (when (gnus-gethash (gnus-group-real-name (symbol-name group))
			      gnus-nocem-real-group-hashtb)

with

	  (when (symbol-value group)

I did not test this, though.
I could submit a patch for it, too, if you are interested.

best regards
-Edwin



Index: lisp/gnus-nocem.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-nocem.el,v
retrieving revision 6.3
diff -u -r6.3 gnus-nocem.el
--- lisp/gnus-nocem.el	17 Nov 2002 22:35:39 -0000	6.3
+++ lisp/gnus-nocem.el	25 Nov 2003 22:32:58 -0000
@@ -297,7 +297,7 @@
       (while (search-forward "\t" nil t)
 	(cond
 	 ((not (ignore-errors
-		 (setq group (let ((obarray gnus-active-hashtb)) (read buf)))))
+		 (setq group (let ((obarray gnus-nocem-real-group-hashtb)) (read buf)))))
 	  ;; An error.
 	  )
 	 ((not (symbolp group))

Re: Patch for gnus-nocem

[Lars Magne Ingebrigtsen]

Edwin Steiner <edwin.steiner@gmx.net> writes:

> The patch below solves this problem. The lookup is now done in
> gnus-nocem-real-group-hashtb which contains the real group names.

Thanks for the patch; I've applied it to Gnus v5.10.4 (i. e., CVS).

> This patch makes the check in the following when clause partially
> redundant. You could substitute
>
> 	  (when (gnus-gethash (gnus-group-real-name (symbol-name group))
> 			      gnus-nocem-real-group-hashtb)
>
> with
>
> 	  (when (symbol-value group)
>
> I did not test this, though.
> I could submit a patch for it, too, if you are interested.

Sure.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen