Gnus development mailing list
 help / color / mirror / Atom feed
From: Pavel.Janik@inet.cz (Pavel Janík ml.)
Cc: ding@gnus.org
Subject: Re: message-setup-hook called when sending from queue?
Date: 26 Apr 2000 17:32:18 +0200	[thread overview]
Message-ID: <m3d7ncev3x.fsf@SnowWhite.inet.cz> (raw)
In-Reply-To: Shenghuo ZHU's message of "26 Apr 2000 04:20:05 -0400"

   From: Shenghuo ZHU <zsh@cs.rochester.edu>
   Date: 26 Apr 2000 04:20:05 -0400

Hi,

   > Pavel> BTW - there is misplaced comment in gnus-draft.el:
   > 
   > Pavel>           ;; Insert the separator.
   > Pavel> ...
   > 
   > In the latest CVS version, I believe I have fixed the gnus-draft-setup
   > bug. Please test it.

I have CVS from about an hour ago and still nothing... This is the fix I'm
using now:

--- gnus-draft.el.orig	Wed Apr 26 17:24:32 2000
+++ gnus-draft.el	Wed Apr 26 17:27:48 2000
@@ -188,21 +188,22 @@
 
 (progn
   (defun gnus-draft-setup (narticle group &optional restore)
-    (gnus-setup-message 'forward
+    (let ((message-setup-hook nil))
+     (gnus-setup-message 'forward
       (let ((article narticle))
 	(message-mail)
 	(erase-buffer)
 	(if (not (gnus-request-restore-buffer article group))
 	    (error "Couldn't restore the article")
-	  ;; Insert the separator.
 	  (if (and restore (equal group "nndraft:queue"))
 	      (mime-to-mml))
+	  ;; Insert the separator.
 	  (goto-char (point-min))
 	  (search-forward "\n\n")
 	  (forward-char -1)
 	  (insert mail-header-separator)
 	  (forward-line 1)
-	  (message-set-auto-save-file-name))))))
+	  (message-set-auto-save-file-name)))))))
 
 (defun gnus-draft-article-sendable-p (article)
   "Say whether ARTICLE is sendable."

BTW - Please move the comment ;; Insert the separator lower where it belongs
as in this patch.
-- 
Pavel Janík ml.
Pavel.Janik@inet.cz



  reply	other threads:[~2000-04-26 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-04-26  7:41 Pavel Janík ml.
2000-04-26  8:20 ` Shenghuo ZHU
2000-04-26 15:32   ` Pavel Janík ml. [this message]
2000-04-26 16:37     ` Shenghuo ZHU
2000-04-26 20:54       ` Pavel Janík ml.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d7ncev3x.fsf@SnowWhite.inet.cz \
    --to=pavel.janik@inet.cz \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).