Picons display oddities

Picons display oddities

[Didier Verna]

	The way picons are displayed in the article buffer (0.65) is weird, I
think. There are several cases (I'm connecting to the network to get them):

If the From header is something like `Her Name <hername@herdomain>', the line
will appear like this in the article buffer:

PICON(hername)@PICONS(herdomain) || From: Her Name <>


If the From header is something like `hername@herdomain (Her Name)', then I
something which looks clearer, but not optimal yet:

PICON(hername)@PICONS(domain) || From: (Her Name)



In any case, I think I'd prefer to see something like:

From: Her Name PICON(hername)@PICONS(herdomain) [hername@herdomain ?]

and maybe an option to let people see the raw email address if they wish.


	Sorry, I have no time to hack today.
-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /      E.N.S.T. INF C201.1      mailto:verna@inf.enst.fr
/_/ / /_/ / /__ /        46 rue Barrault        Tel.   (33) 01 45 81 73 46
                      75634 Paris  cedex 13     Fax.   (33) 01 45 81 31 19

Re: Picons display oddities

[Lars Magne Ingebrigtsen]

Didier Verna <verna@inf.enst.fr> writes:

> In any case, I think I'd prefer to see something like:
> 
> From: Her Name PICON(hername)@PICONS(herdomain) [hername@herdomain ?]

That's what happens when I use picons.  It kinda sounds like the
function is having difficulty in finding the From line, or it's being
run twice.  Do you have the picons functions twice in your
`gnus-article-display-hook'? 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Picons display oddities

[Didier Verna]

Lars Magne Ingebrigtsen writes:

Lars> That's what happens when I use picons. It kinda sounds like the function
Lars> is having difficulty in finding the From line, or it's being run twice. 

	I checked. It finds correctly all the parameters.


Lars> Do you have the picons functions twice in your
Lars> `gnus-article-display-hook'?

	Nope. My current value is this:

 ,----
| (gnus-article-add-buttons   
| gnus-article-add-buttons-to-head
| gnus-article-emphasize	    
| gnus-article-highlight	    
| gnus-smiley-display	    
| gnus-article-hide-headers-if-wanted
| gnus-article-hide-boring-headers
| gnus-article-treat-overstrike
| gnus-article-maybe-highlight
| gnus-article-display-x-face 
| gnus-article-display-picons)
`-----

	I don't fully understand this stuff, but AFAICS, when the annotations
are prepared to display the picons, the (point) in the article buffer is
always 1 (ie just before `From:'). I guess that's a problem ?


-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /      E.N.S.T. INF C201.1      mailto:verna@inf.enst.fr
/_/ / /_/ / /__ /        46 rue Barrault        Tel.   (33) 01 45 81 73 46
                      75634 Paris  cedex 13     Fax.   (33) 01 45 81 31 19

Re: Picons display oddities

[Lars Magne Ingebrigtsen]

Didier Verna <verna@inf.enst.fr> writes:

> 	I don't fully understand this stuff, but AFAICS, when the annotations
> are prepared to display the picons, the (point) in the article buffer is
> always 1 (ie just before `From:'). I guess that's a problem ?

I think I've located and fixed this bug.  Could you check after
Pterodactyl Gnus v0.66 has been released to see whether things start
working?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Picons display oddities

[Didier Verna]

Lars Magne Ingebrigtsen writes:

Lars> I think I've located and fixed this bug. Could you check after
Lars> Pterodactyl Gnus v0.66 has been released to see whether things start
Lars> working?

	OK, I think this is fixed... like, almost ;-)
Now it seems that when an article is displayed, and gnus connects to the
server to get the picons, they don't appear in the article. However, after
they're loaded, if I leave the article and enter it again, they're here.

-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /      E.N.S.T. INF C201.1      mailto:verna@inf.enst.fr
/_/ / /_/ / /__ /        46 rue Barrault        Tel.   (33) 01 45 81 73 46
                      75634 Paris  cedex 13     Fax.   (33) 01 45 81 31 19

Re: Picons display oddities

[Lars Magne Ingebrigtsen]

Didier Verna <verna@inf.enst.fr> writes:

> Now it seems that when an article is displayed, and gnus connects to the
> server to get the picons, they don't appear in the article. However, after
> they're loaded, if I leave the article and enter it again, they're here.

I don't use the dowloading picons thingie.  Could you try to debug
this? 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Picons display oddities

[Didier Verna]

Lars Magne Ingebrigtsen writes:

Lars> Didier Verna <verna@inf.enst.fr> writes:
>> Now it seems that when an article is displayed, and gnus connects to the
>> server to get the picons, they don't appear in the article. However, after
>> they're loaded, if I leave the article and enter it again, they're here.

Lars> I don't use the dowloading picons thingie. Could you try to debug this?

	The picons are displayed, but in random buffers! I often end up with
picons in the *Group* buffer when they are fetched from the network (not being 
present in the cache). I tried to ensure that each call to
`gnus-picons-make-annotation' is done in `gnus-picons-buffer-name', but then I 
get the old bug back (picons at the beginning of the line). I'm a bit confused 
by all this code and don't have much more time for this right now. Sorry.


-- 
    /     /   _   _       Didier Verna        http://www.inf.enst.fr/~verna/
 - / / - / / /_/ /      E.N.S.T. INF C201.1      mailto:verna@inf.enst.fr
/_/ / /_/ / /__ /        46 rue Barrault        Tel.   (33) 01 45 81 73 46
                      75634 Paris  cedex 13     Fax.   (33) 01 45 81 31 19