gnus-summary-repair-multipart (K m) not working in nndoc

gnus-summary-repair-multipart (K m) not working in nndoc

[Vladimir Volovich]

Hi,

when i try to `repair' messages in nndoc (after pressing C-d on a
digest message) i get an error:

Signaling: (void-function nndoc-request-replace-article)
  nndoc-request-replace-article(34 "nnmbox:linux-kernel-digest-1277" #<buffer  *temp*<2>>)
  gnus-request-replace-article(34 "nndoc:nnmbox:linux-kernel-digest-1277" #<buffer  *temp*<2>> t)
  gnus-summary-repair-multipart(34)
* call-interactively(gnus-summary-repair-multipart)

	Best regards, -- Vladimir.

Re: gnus-summary-repair-multipart (K m) not working in nndoc

[Vladimir Volovich]

"KS" == Kurt Swanson writes:

 KS> It seems that message repairs are only intended to work on local,
 KS> permanent back-ends.

then this is not as useful as it could be. often broken multiparts are
in digests.

	Best regards, -- Vladimir.

Re: gnus-summary-repair-multipart (K m) not working in nndoc

[Lars Magne Ingebrigtsen]

Vladimir Volovich <vvv@vvv.vsu.ru> writes:

> when i try to `repair' messages in nndoc (after pressing C-d on a
> digest message) i get an error:

Yup.  Fix in Pterodactyl Gnus v0.59.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-summary-repair-multipart (K m) not working in nndoc

[Vladimir Volovich]

"LMI" == Lars Magne Ingebrigtsen writes:

 >> when i try to `repair' messages in nndoc (after pressing C-d on a
 >> digest message) i get an error:
 LMI> Yup.  Fix in Pterodactyl Gnus v0.59.

Well. The current implementation of gnus-summary-repair-multipart
seems to be not 100% safe, because it only looks for "\n--" to find a
part boundary. So, it can easily break the message by treating e.g. a
signature beginning as a MIME boundary. IMHO, one should at least do
something like (looking-at "[\41-\176]+$") [or whatever is an allowed
characters for boundary], and also, even better, to make reparing only
if there is a line "^--boundary--$", too.

I'd also be happy if gnus-summary-repair-multipart could be made
`non-destructive', i.e. only `repair' in the memory while viewing, but
not replacing the message, so that one could safely put it into, say,
message-prepare-hook.

	Best regards, -- Vladimir.

Re: gnus-summary-repair-multipart (K m) not working in nndoc

[Lars Magne Ingebrigtsen]

Vladimir Volovich <vvv@vvv.vsu.ru> writes:

> I'd also be happy if gnus-summary-repair-multipart could be made
> `non-destructive', i.e. only `repair' in the memory while viewing, but
> not replacing the message, so that one could safely put it into, say,
> message-prepare-hook.

No, you'd never be able to do that.  The command is supposed to make
Gnus understand messages that have been destroyed during transport.
There may be only one thing that looks like a boundary, and the
command has to guess.  There's no way to make it safe.  

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen