From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66328 Path: news.gmane.org!not-for-mail From: Barry Fishman Newsgroups: gmane.emacs.gnus.general Subject: Problems with Easynews active file (with patch) Date: Sat, 16 Feb 2008 13:08:59 -0500 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1203189728 28146 80.91.229.12 (16 Feb 2008 19:22:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 19:22:08 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M14819@lists.math.uh.edu Sat Feb 16 20:22:31 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQScE-0001HQ-LV for ding-account@gmane.org; Sat, 16 Feb 2008 20:22:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JQSaw-0000b3-HX; Sat, 16 Feb 2008 13:21:06 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JQSQQ-0000Wg-Ut for ding@lists.math.uh.edu; Sat, 16 Feb 2008 13:10:15 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JQSQK-0007Eg-5t for ding@lists.math.uh.edu; Sat, 16 Feb 2008 13:10:14 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JQSQO-0007W3-00 for ; Sat, 16 Feb 2008 20:10:12 +0100 Original-Received: from root by ciao.gmane.org with local (Exim 4.43) id 1JQSQE-0003hD-Rv for ding@gnus.org; Sat, 16 Feb 2008 19:10:02 +0000 Original-Received: from fl-71-0-147-208.dhcp.embarqhsd.net ([71.0.147.208]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Feb 2008 19:10:02 +0000 Original-Received: from barry_fishman by fl-71-0-147-208.dhcp.embarqhsd.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Feb 2008 19:10:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 82 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: fl-71-0-147-208.dhcp.embarqhsd.net User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:fuNb6YCc+zcWWs/ysiGcIzhTdbo= X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66328 Archived-At: A question about this was posted by Hynek Schlawack on Oct 7 but did not receive a response. > 1) Server-Browsing (^) of Easynews fails after some groups with the error: > > Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p > Wellfleet) > gnus-browse-foreign-server("nntp:news.easynews.com" # gnus-server-read-server("nntp:news.easynews.com") > call-interactively(gnus-server-read-server) This is due to easynews containing several bogus lines in its "list active" response, such as: comp.dcom.sys.wellfleet Wellfleet bridge router I set a message about the problem to EasyNews support. One can patch around this by changing gnus-ignored-newsgroups to: (setq gnus-ignored-newsgroups (mapconcat 'identity '("^to\\." ; not "real" groups "^[0-9. \t]+\\( \\|$\\)" ; all digits in name "^[\"][]\"[#'()]" ; bogus characters "^[^ ]+ [^0-9]+$" ; No digits fields (for easynews) ) "\\|")) But shouldn't gnus-browse-foreign-server validate the numeric fields before using them, as is done in gnus-active-to-gnus-format? The following patch seems to work: Index: gnus-srvr.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-srvr.el,v retrieving revision 7.33 diff -c -r7.33 gnus-srvr.el *** gnus-srvr.el 20 Jan 2008 05:23:57 -0000 7.33 --- gnus-srvr.el 16 Feb 2008 18:03:02 -0000 *************** *** 726,741 **** (if (eq (car method) 'nntp) (while (not (eobp)) (ignore-errors ! (push (cons ! (mm-string-as-unibyte ! (buffer-substring ! (point) ! (progn ! (skip-chars-forward "^ \t") ! (point)))) ! (let ((last (read cur))) ! (cons (read cur) last))) ! groups)) (forward-line)) (while (not (eobp)) (ignore-errors --- 726,743 ---- (if (eq (car method) 'nntp) (while (not (eobp)) (ignore-errors ! (let ((group (cons ! (mm-string-as-unibyte ! (buffer-substring ! (point) ! (progn ! (skip-chars-forward "^ \t") ! (point)))) ! (let ((last (read cur))) ! (cons (read cur) last))))) ! (if (and (numberp (cadr group)) ! (numberp (cddr group))) ! (push group groups)))) (forward-line)) (while (not (eobp)) (ignore-errors -- Barry Fishman