Re: Use of ecomplete.el in message.el

[Lars Magne Ingebrigtsen <larsi@gnus.org>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> - In `message-put-addresses-in-ecomplete' you should use
>   `gnus-replace-in-string' instead of `replace-regexp-in-string' for
>   compatibility with XEmacs.

Fixed.

> - Wouldn't (autoload 'ecomplete-setup "ecomplete") be sufficient
>   instead of (require 'ecomplete)?

Then I'd get compilation warnings on all the other ecomplete
functions, wouldn't I?

> - Maybe it would be better to use a file under ~/.emacs.d/ or
>   ~/.xemacs/ for `ecomplete-database-file'.  See e.g. `savehist-file'
>   (recent addition to Emacs).

Hm.  Couldn't find `savehist-file'...

> - (defgroup ecomplete nil
>     "Suppression of duplicate articles."
>     :group 'mail)
>
>   Copy and paste error?

Yup; fixed.

> - You might want to set `show-trailing-whitespace' to t in
>   emacs-lisp-mode and change-log-mode or use `M-x
>   delete-trailing-whitespace RET' from time to time .  ;-)

Oh, have we changed to deleting trailing whitespace in all the files? 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen