gnus-treat-body-highlight-signature redux

gnus-treat-body-highlight-signature redux

[Lars Magne Ingebrigtsen]

And all the other highlighting/washing variables.

Ok; we then have a bunch of variables that say what
highlighting/washing is to be done.  Only text/plain parts should have
this washing applied.  However, some highlighting functions should be
applied to all text/plain parts, while others only to some.  For
instance, the signature highlighting thing should probably only be
applied to the final text/plain part.

So -- we have the following valid values:

nil -- don't do it
t -- always do it
last -- only do it on the last part
N -- a number; only do it on parts smaller than N

These aren't exactly orthogonal values, but perhaps that's not a
problem.

Will This Do?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-treat-body-highlight-signature redux

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> nil -- don't do it
> t -- always do it
> last -- only do it on the last part
> N -- a number; only do it on parts smaller than N
> 
> These aren't exactly orthogonal values, but perhaps that's not a
> problem.
> 
> Will This Do?

Please implement these things as plists, as I proposed.  That will
make the much easier to extend.  For example:

(defvar gnus-some-citation-variable-or-other
        '(max-size 100000 relevant-parts last ...))

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
Ask not for whom the <CONTROL-G> tolls.

Re: gnus-treat-body-highlight-signature redux

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Please implement these things as plists, as I proposed.  That will
> make the much easier to extend.  For example:
> 
> (defvar gnus-some-citation-variable-or-other
>         '(max-size 100000 relevant-parts last ...))

But wasn't the general idea to make the syntax as simple as possible
for easy Custom-ization?  The nil/t/number/last/header thing gives a
very simple menu to choose from...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-treat-body-highlight-signature redux

[Per Abrahamsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
> > Please implement these things as plists, as I proposed.  That will
> > make the much easier to extend.  For example:
> > 
> > (defvar gnus-some-citation-variable-or-other
> >         '(max-size 100000 relevant-parts last ...))
> 
> But wasn't the general idea to make the syntax as simple as possible
> for easy Custom-ization?  The nil/t/number/last/header thing gives a
> very simple menu to choose from...

Hrvoje's scheme could be implemented with an "on/off/advanced" (nil,
t, plist) menu choice.  That would give a simple interface for the
common case.

On the other hand, your scheme is also extensible, it would just be
(nil, t, number, last, plist).

Re: gnus-treat-body-highlight-signature redux

[Lars Magne Ingebrigtsen]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> On the other hand, your scheme is also extensible, it would just be
> (nil, t, number, last, plist).

Would this be the right way to do it?

(defcustom gnus-treat-body-highlight-signature t
  "Highlight the signature."
  :group 'gnus-article
  :type '(choice (const :tag "Off" nil)
		 (const :tag "On" t)
		 (const :tag "Last" last)
		 (integer :tag "Less")
		 (sexp :tag "Predicate")))

And then the predicate would be as I described before, more or less. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-treat-body-highlight-signature redux

[Hrvoje Niksic]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Per Abrahamsen <abraham@dina.kvl.dk> writes:
> 
> > On the other hand, your scheme is also extensible, it would just be
> > (nil, t, number, last, plist).
> 
> Would this be the right way to do it?
> 
> (defcustom gnus-treat-body-highlight-signature t
>   "Highlight the signature."
>   :group 'gnus-article
>   :type '(choice (const :tag "Off" nil)
> 		 (const :tag "On" t)
> 		 (const :tag "Last" last)
> 		 (integer :tag "Less")
> 		 (sexp :tag "Predicate")))
> 
> And then the predicate would be as I described before, more or less.

I have no idea what predicate is, but if you mean the plist as I
described it, you could use fancier stuff than `sexp'.

-- 
Hrvoje Niksic <hniksic@srce.hr> | Student at FER Zagreb, Croatia
--------------------------------+--------------------------------
main(){printf(&unix["\021%six\012\0"],(unix)["have"]+"fun"-0x60);}

Re: gnus-treat-body-highlight-signature redux

[Lars Magne Ingebrigtsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> I have no idea what predicate is, but if you mean the plist as I
> described it, you could use fancier stuff than `sexp'.

No, the predicate would look something like:

(and (not header) (or (less 10) last))

Which is a sexp, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-treat-body-highlight-signature redux

[Per Abrahamsen]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> No, the predicate would look something like:
> 
> (and (not header) (or (less 10) last))
> 
> Which is a sexp, I guess.

Then you can't later add plist support.

Re: gnus-treat-body-highlight-signature redux

[Lars Magne Ingebrigtsen]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

> > Which is a sexp, I guess.
> 
> Then you can't later add plist support.

Yes.  I don't want plist support.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: gnus-treat-body-highlight-signature redux

[Per Abrahamsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> 
> > Per Abrahamsen <abraham@dina.kvl.dk> writes:
> > 
> > > On the other hand, your scheme is also extensible, it would just be
> > > (nil, t, number, last, plist).
> > 
> > Would this be the right way to do it?
> > 
> [ ... ]
> I have no idea what predicate is, but if you mean the plist as I
> described it, you could use fancier stuff than `sexp'.

What Hrvoje said.  

You don't need to implement the plist right away, just start with the
on/off/first N/last, and then add plists when need arises.